Deprecate implode() with swapped parameter order

Author: nikic

Zend/tests/unexpected_ref_bug.phpt

@@ -15,5 +15,6 @@ $my_var=array(1,2,3);
 $data = call_user_func_array("implode",array(&$my_var, new Test()));
 echo "Done.\n";
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 Done.

ext/standard/string.c

@@ -1292,6 +1292,8 @@ PHP_FUNCTION(implode)
 		if (Z_TYPE_P(arg1) == IS_ARRAY) {
 			glue = zval_get_tmp_string(arg2, &tmp_glue);
 			pieces = arg1;
+			php_error_docref(NULL, E_DEPRECATED,
+				"Passing glue string after array is deprecated. Swap the parameters");
 		} else if (Z_TYPE_P(arg2) == IS_ARRAY) {
 			glue = zval_get_tmp_string(arg1, &tmp_glue);
 			pieces = arg2;

ext/standard/tests/strings/explode_variation7.phpt

@@ -11,7 +11,7 @@ edgarsandi - <[email protected]>
  * Source code: ext/standard/string.c
 */
 
-var_dump(count(explode('|', implode(range(1,65),'|'), -1)));
+var_dump(count(explode('|', implode('|', range(1,65)), -1)));
 
 ?>
 --EXPECT--

ext/standard/tests/strings/implode1.phpt

@@ -123,22 +123,32 @@ string(19) "element10.5element2"
 -- Iteration 10 --
 
 Notice: Array to string conversion in %s on line %d
+
+Deprecated: join(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 string(0) ""
 -- Iteration 11 --
 
 Notice: Array to string conversion in %s on line %d
+
+Deprecated: join(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 string(1) "0"
 -- Iteration 12 --
 
 Notice: Array to string conversion in %s on line %d
+
+Deprecated: join(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 string(1) "1"
 -- Iteration 13 --
 
 Notice: Array to string conversion in %s on line %d
+
+Deprecated: join(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 string(7) "1Array2"
 -- Iteration 14 --
 
 Notice: Array to string conversion in %s on line %d
+
+Deprecated: join(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 string(11) "redArraypen"
 -- Iteration 15 --
 string(17) "element11element2"

ext/standard/tests/strings/join_variation1.phpt

@@ -39,6 +39,8 @@ Notice: Array to string conversion in %s on line %d
 string(27) "ArrayTESTArrayTESTPHPTEST50"
 
 Notice: Array to string conversion in %s on line %d
+
+Deprecated: join(): Passing glue string after array is deprecated. Swap the parameters in %s on line %d
 string(19) "1Array2Array3Array4"
 
 Notice: Array to string conversion in %s on line %d