Fix [-Wimplicit-fallthrough] warnings in FFI extension

Girgias · Girgias · commit 4d174ff36ccf · 2020-10-01T20:31:52.000+01:00
diff --git a/ext/ffi/ffi.c b/ext/ffi/ffi.c
@@ -2594,7 +2594,7 @@ static int zend_ffi_pass_var_arg(zval *arg, ffi_type **pass_type, void **arg_val
 
 				return zend_ffi_pass_arg(arg, type, pass_type, arg_values, n, execute_data);
 			}
-			/* break missing intentionally */
+			fallthrough;
 		default:
 			zend_throw_error(zend_ffi_exception_ce, "Unsupported argument type");
 			return FAILURE;

Original file line number	Diff line number	Diff line change
`@@ -2594,7 +2594,7 @@ static int zend_ffi_pass_var_arg(zval arg, ffi_type pass_type, void *arg_val`
`2594`	`2594`
`2595`	`2595`	`return zend_ffi_pass_arg(arg, type, pass_type, arg_values, n, execute_data);`
`2596`	`2596`	`}`
`2597`		`- /* break missing intentionally */`
	`2597`	`+ fallthrough;`
`2598`	`2598`	`default:`
`2599`	`2599`	`zend_throw_error(zend_ffi_exception_ce, "Unsupported argument type");`
`2600`	`2600`	`return FAILURE;`