Tweak MT_RAND_PHP deprecation message

DanielEScherzer · DanielEScherzer · commit 4e8afe713b09 · 2025-06-26T10:46:44.000-07:00
diff --git a/ext/random/random.stub.php b/ext/random/random.stub.php
@@ -12,7 +12,7 @@
      * @var int
      * @cvalue MT_RAND_PHP
      */
-    #[\Deprecated(since: '8.3', message: 'as it uses a problematic version of Mt19937')]
+    #[\Deprecated(since: '8.3', message: 'as it uses a biased non-standard variant of Mt19937')]
     const MT_RAND_PHP = UNKNOWN;
 
     #[\Deprecated(since: '8.4', message: "use \\Random\\Randomizer::getFloat() instead")]
diff --git a/ext/random/random_arginfo.h b/ext/random/random_arginfo.h
diff --git a/ext/random/tests/01_functions/array_rand_mt_rand_php.phpt b/ext/random/tests/01_functions/array_rand_mt_rand_php.phpt
@@ -24,7 +24,7 @@ var_dump(
 );
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 string(11) "found key 0"
diff --git a/ext/random/tests/01_functions/bug75514.phpt b/ext/random/tests/01_functions/bug75514.phpt
@@ -6,7 +6,7 @@ mt_srand(0, MT_RAND_PHP);
 var_dump(mt_rand(0,999999999), mt_rand(0,999));
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 int(448865905)
diff --git a/ext/random/tests/01_functions/mt_rand_value.phpt b/ext/random/tests/01_functions/mt_rand_value.phpt
@@ -38,7 +38,7 @@ echo $x.PHP_EOL;
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 1614640687
diff --git a/ext/random/tests/03_randomizer/compatibility_mt_rand.phpt b/ext/random/tests/03_randomizer/compatibility_mt_rand.phpt
@@ -46,11 +46,11 @@ die('success');
 --EXPECTF--
 MT_RAND_PHP
 
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 MT_RAND_MT19937
diff --git a/ext/random/tests/03_randomizer/methods/getBytes.phpt b/ext/random/tests/03_randomizer/methods/getBytes.phpt
@@ -39,7 +39,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/getBytesFromString.phpt b/ext/random/tests/03_randomizer/methods/getBytesFromString.phpt
@@ -43,7 +43,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/getFloat.phpt b/ext/random/tests/03_randomizer/methods/getFloat.phpt
@@ -42,7 +42,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/getInt.phpt b/ext/random/tests/03_randomizer/methods/getInt.phpt
@@ -46,7 +46,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/nextFloat.phpt b/ext/random/tests/03_randomizer/methods/nextFloat.phpt
@@ -41,7 +41,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/nextInt.phpt b/ext/random/tests/03_randomizer/methods/nextInt.phpt
@@ -41,7 +41,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/pickArrayKeys.phpt b/ext/random/tests/03_randomizer/methods/pickArrayKeys.phpt
@@ -76,7 +76,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/shuffleArray.phpt b/ext/random/tests/03_randomizer/methods/shuffleArray.phpt
@@ -45,7 +45,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/methods/shuffleBytes.phpt b/ext/random/tests/03_randomizer/methods/shuffleBytes.phpt
@@ -52,7 +52,7 @@ die('success');
 
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
diff --git a/ext/random/tests/03_randomizer/serialize.phpt b/ext/random/tests/03_randomizer/serialize.phpt
@@ -43,7 +43,7 @@ foreach ($engines as $engine) {
 die('success');
 ?>
 --EXPECTF--
-Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a problematic version of Mt19937 in %s on line %d
+Deprecated: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937 in %s on line %d
 
 Deprecated: The MT_RAND_PHP variant of Mt19937 is deprecated in %s on line %d
 Random\Engine\Mt19937
