ext/dba: Fix runtime nonnull warning

Girgias · Girgias · commit 5ccbb9632fc4 · 2025-05-06T21:12:51.000+01:00
diff --git a/ext/dba/dba.c b/ext/dba/dba.c
@@ -975,11 +975,11 @@ PHP_FUNCTION(dba_close)
 
 	bool persistent = connection->info->flags & DBA_PERSISTENT;
 
-	dba_close_connection(connection);
-
 	if (persistent) {
 		zend_hash_apply_with_argument(&EG(persistent_list), remove_pconnection_from_list, (void *) connection->info);
 	}
+
+	dba_close_connection(connection);
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -975,11 +975,11 @@ PHP_FUNCTION(dba_close)`
`975`	`975`
`976`	`976`	`bool persistent = connection->info->flags & DBA_PERSISTENT;`
`977`	`977`
`978`		`- dba_close_connection(connection);`
`979`		`-`
`980`	`978`	`if (persistent) {`
`981`	`979`	`zend_hash_apply_with_argument(&EG(persistent_list), remove_pconnection_from_list, (void *) connection->info);`
`982`	`980`	`}`
	`981`	`+`
	`982`	`+ dba_close_connection(connection);`
`983`	`983`	`}`
`984`	`984`	`/* }}} */`
`985`	`985`