Normalize gmp_cmp() to -1/0/+1

Girgias · Girgias · commit 5d2b47396335 · 2024-11-27T15:01:37.000Z
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
@@ -477,7 +477,8 @@ static int gmp_compare(zval *op1, zval *op2) /* {{{ */
 		}
 		return ZEND_UNCOMPARABLE;
 	}
-	return mpz_cmp(gmp_op1, gmp_op2);
+
+	return ZEND_THREEWAY_COMPARE(mpz_cmp(gmp_op1, gmp_op2), 0);
 }
 /* }}} */
 
@@ -1432,7 +1433,7 @@ ZEND_FUNCTION(gmp_cmp)
 		GMP_Z_PARAM_INTO_MPZ_PTR(gmpnum_b)
 	ZEND_PARSE_PARAMETERS_END();
 
-	RETURN_LONG(mpz_cmp(gmpnum_a, gmpnum_b));
+	RETURN_LONG(ZEND_THREEWAY_COMPARE(mpz_cmp(gmpnum_a, gmpnum_b), 0));
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -477,7 +477,8 @@ static int gmp_compare(zval op1, zval op2) /* {{{ */`
`477`	`477`	`}`
`478`	`478`	`return ZEND_UNCOMPARABLE;`
`479`	`479`	`}`
`480`		`- return mpz_cmp(gmp_op1, gmp_op2);`
	`480`	`+`
	`481`	`+ return ZEND_THREEWAY_COMPARE(mpz_cmp(gmp_op1, gmp_op2), 0);`
`481`	`482`	`}`
`482`	`483`	`/* }}} */`
`483`	`484`
`@@ -1432,7 +1433,7 @@ ZEND_FUNCTION(gmp_cmp)`
`1432`	`1433`	`GMP_Z_PARAM_INTO_MPZ_PTR(gmpnum_b)`
`1433`	`1434`	`ZEND_PARSE_PARAMETERS_END();`
`1434`	`1435`
`1435`		`- RETURN_LONG(mpz_cmp(gmpnum_a, gmpnum_b));`
	`1436`	`+ RETURN_LONG(ZEND_THREEWAY_COMPARE(mpz_cmp(gmpnum_a, gmpnum_b), 0));`
`1436`	`1437`	`}`
`1437`	`1438`	`/* }}} */`
`1438`	`1439`