Skip to content

Commit 5d7c21f

Browse files
committed
do not use "escapeshellarg" function as it generates different results on Windows vs. linux
1 parent 285de52 commit 5d7c21f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/scripts/download-bundled/make-workflow-file.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public function makeWorkflowFile(): void
147147
'.github/scripts/download-bundled/' . $bundle->getNameForPath() . '.sh',
148148
'echo "::endgroup::"',
149149
'echo "::group::Verify files"',
150-
...array_map(static fn ($v) => '.github/scripts/test-directory-unchanged.sh ' . escapeshellarg($v), $bundle->directories),
150+
...array_map(static fn ($v) => '.github/scripts/test-directory-unchanged.sh \'' . $v . '\'', $bundle->directories),
151151
'echo "::endgroup::"',
152152
]),
153153
];

.github/workflows/verify-bundled-files.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
.github/scripts/download-bundled/boost-context.sh
4747
echo "::endgroup::"
4848
echo "::group::Verify files"
49-
.github/scripts/test-directory-unchanged.sh "Zend/asm"
49+
.github/scripts/test-directory-unchanged.sh 'Zend/asm'
5050
echo "::endgroup::"
5151
- name: PCRE2
5252
if: ${{ !cancelled() && (steps.changes.outputs.pcre2 == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') }}
@@ -55,7 +55,7 @@ jobs:
5555
.github/scripts/download-bundled/pcre2.sh
5656
echo "::endgroup::"
5757
echo "::group::Verify files"
58-
.github/scripts/test-directory-unchanged.sh "ext/pcre/pcre2lib"
58+
.github/scripts/test-directory-unchanged.sh 'ext/pcre/pcre2lib'
5959
echo "::endgroup::"
6060
- name: uriparser
6161
if: ${{ !cancelled() && (steps.changes.outputs.uriparser == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') }}
@@ -64,5 +64,5 @@ jobs:
6464
.github/scripts/download-bundled/uriparser.sh
6565
echo "::endgroup::"
6666
echo "::group::Verify files"
67-
.github/scripts/test-directory-unchanged.sh "ext/uri/uriparser"
67+
.github/scripts/test-directory-unchanged.sh 'ext/uri/uriparser'
6868
echo "::endgroup::"

0 commit comments

Comments
 (0)