Decrease the reference count before calling zend_list_close()

SakiTakamachi · SakiTakamachi · commit 62b76bf39e3e · 2025-06-27T20:34:09.000+09:00
diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
@@ -573,12 +573,8 @@ void php_oci_column_hash_dtor(zval *data)
 		zend_list_close(column->stmtid);
 	}
 
-	if (column->descid) {
-		if (GC_REFCOUNT(column->descid) == 1)
-			zend_list_close(column->descid);
-		else {
-			GC_DELREF(column->descid);
-		}
+	if (column->descid && !GC_DELREF(column->descid)) {
+		zend_list_close(column->descid);
 	}
 
 	if (column->data) {

Original file line number	Diff line number	Diff line change
`@@ -573,12 +573,8 @@ void php_oci_column_hash_dtor(zval *data)`
`573`	`573`	`zend_list_close(column->stmtid);`
`574`	`574`	`}`
`575`	`575`
`576`		`- if (column->descid) {`
`577`		`- if (GC_REFCOUNT(column->descid) == 1)`
`578`		`- zend_list_close(column->descid);`
`579`		`- else {`
`580`		`- GC_DELREF(column->descid);`
`581`		`- }`
	`576`	`+ if (column->descid && !GC_DELREF(column->descid)) {`
	`577`	`+ zend_list_close(column->descid);`
`582`	`578`	`}`
`583`	`579`
`584`	`580`	`if (column->data) {`