Added NULL check for H->db in firebird_handle_closer

SakiTakamachi · SakiTakamachi · commit 6558bda5062e · 2025-03-15T09:00:49.000+09:00
diff --git a/ext/pdo_firebird/firebird_driver.c b/ext/pdo_firebird/firebird_driver.c
@@ -594,7 +594,8 @@ static void firebird_handle_closer(pdo_dbh_t *dbh) /* {{{ */
 	}
 	H->in_manually_txn = 0;
 
-	if (isc_detach_database(H->isc_status, &H->db)) {
+	/* isc_detach_database returns 0 on success, 1 on failure. */
+	if (H->db != NULL && isc_detach_database(H->isc_status, &H->db)) {
 		php_firebird_error(dbh);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -594,7 +594,8 @@ static void firebird_handle_closer(pdo_dbh_t dbh) / {{{ */`
`594`	`594`	`}`
`595`	`595`	`H->in_manually_txn = 0;`
`596`	`596`
`597`		`- if (isc_detach_database(H->isc_status, &H->db)) {`
	`597`	`+ /* isc_detach_database returns 0 on success, 1 on failure. */`
	`598`	`+ if (H->db != NULL && isc_detach_database(H->isc_status, &H->db)) {`
`598`	`599`	`php_firebird_error(dbh);`
`599`	`600`	`}`
`600`	`601`