Fix GH-14603: invalid null zip file entry.

devnexen · devnexen · commit 686afc10bfe2 · 2024-06-21T05:07:46.000+01:00
close GH-14610
diff --git a/NEWS b/NEWS
@@ -2,6 +2,10 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? ????, PHP 8.2.22
 
+- Phar:
+  . Fixed bug GH-14603 (null string from zip entry).
+    (David Carlier)
+
 - PHPDBG:
   . Fixed bug GH-14596 (crashes with ASAN and ZEND_RC_DEBUG=1).
     (David Carlier)
diff --git a/ext/phar/tests/gh14603.phpt b/ext/phar/tests/gh14603.phpt
diff --git a/ext/phar/zip.c b/ext/phar/zip.c
@@ -771,7 +771,7 @@ int phar_parse_zipfile(php_stream *fp, char *fname, size_t fname_len, char *alia
 				}
 			}
 
-			zend_hash_str_add_ptr(&(PHAR_G(phar_alias_map)), actual_alias, mydata->alias_len, mydata);
+			zend_hash_str_add_ptr(&(PHAR_G(phar_alias_map)), alias, alias_len, mydata);
 			mydata->alias = pestrndup(alias, alias_len, mydata->is_persistent);
 			mydata->alias_len = alias_len;
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -771,7 +771,7 @@ int phar_parse_zipfile(php_stream fp, char fname, size_t fname_len, char *alia`
`771`	`771`	`}`
`772`	`772`	`}`
`773`	`773`
`774`		`- zend_hash_str_add_ptr(&(PHAR_G(phar_alias_map)), actual_alias, mydata->alias_len, mydata);`
	`774`	`+ zend_hash_str_add_ptr(&(PHAR_G(phar_alias_map)), alias, alias_len, mydata);`
`775`	`775`	`mydata->alias = pestrndup(alias, alias_len, mydata->is_persistent);`
`776`	`776`	`mydata->alias_len = alias_len;`
`777`	`777`	`} else {`