Skip to content

Commit 699e563

Browse files
[RFC] Deprecate curl_share_close() (#19452)
https://wiki.php.net/rfc/deprecations_php_8_5
1 parent 9b13bb1 commit 699e563

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

ext/curl/curl.stub.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3811,6 +3811,7 @@ function curl_setopt_array(CurlHandle $handle, array $options): bool {}
38113811

38123812
function curl_setopt(CurlHandle $handle, int $option, mixed $value): bool {}
38133813

3814+
#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
38143815
function curl_share_close(CurlShareHandle $share_handle): void {}
38153816

38163817
function curl_share_errno(CurlShareHandle $share_handle): int {}

ext/curl/curl_arginfo.h

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/curl/tests/curl_share_close_basic001.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ curl_share_close($sh);
1313
var_dump($sh);
1414

1515
?>
16-
--EXPECT--
16+
--EXPECTF--
1717
object(CurlShareHandle)#1 (0) {
1818
}
19+
20+
Deprecated: Function curl_share_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
1921
object(CurlShareHandle)#1 (0) {
2022
}

0 commit comments

Comments
 (0)