Skip to content

Commit 6ee0ef1

Browse files
committed
zend_builtin_functions: Simplify error path for clone()
1 parent e2bd32c commit 6ee0ef1

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

Zend/zend_builtin_functions.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,11 @@ ZEND_FUNCTION(clone)
105105

106106
zend_object *cloned;
107107
cloned = zobj->handlers->clone_obj(zobj);
108-
109-
if (EG(exception)) {
110-
if (cloned) {
111-
OBJ_RELEASE(cloned);
112-
}
113108

114-
RETURN_THROWS();
109+
ZEND_ASSERT(cloned || EG(exception));
110+
if (EXPECTED(cloned)) {
111+
RETURN_OBJ(cloned);
115112
}
116-
117-
RETURN_OBJ(cloned);
118113
}
119114

120115
ZEND_FUNCTION(exit)

0 commit comments

Comments
 (0)