property_get_default(): update class constants

DanielEScherzer · DanielEScherzer · commit 77b8ec195414 · 2024-10-21T15:28:53.000-07:00
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -884,7 +884,10 @@ static zval *property_get_default(zend_property_info *prop_info) {
 		ZVAL_DEINDIRECT(prop);
 		return prop;
 	} else {
-		return &ce->default_properties_table[OBJ_PROP_TO_NUM(prop_info->offset)];
+		if (UNEXPECTED(zend_update_class_constants(ce) != SUCCESS)) {
+			return &EG(uninitialized_zval);
+		}
+		return &CE_DEFAULT_PROPERTIES_TABLE(ce)[OBJ_PROP_TO_NUM(prop_info->offset)];
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -884,7 +884,10 @@ static zval property_get_default(zend_property_info prop_info) {`
`884`	`884`	`ZVAL_DEINDIRECT(prop);`
`885`	`885`	`return prop;`
`886`	`886`	`} else {`
`887`		`- return &ce->default_properties_table[OBJ_PROP_TO_NUM(prop_info->offset)];`
	`887`	`+ if (UNEXPECTED(zend_update_class_constants(ce) != SUCCESS)) {`
	`888`	`+ return &EG(uninitialized_zval);`
	`889`	`+ }`
	`890`	`+ return &CE_DEFAULT_PROPERTIES_TABLE(ce)[OBJ_PROP_TO_NUM(prop_info->offset)];`
`888`	`891`	`}`
`889`	`892`	`}`
`890`	`893`