Only use array templates with opcache

With opache, arrays are marked as immutable. Without opcache, nested arrays need
refcounting, and thus require a loop over its elements.

Author: iluuu1994

Zend/zend_compile.c

@@ -9792,7 +9792,7 @@ static bool zend_try_ct_eval_array(zval *result, zend_ast *ast, bool allow_templ
 	zend_ast *last_elem_ast = NULL;
 	uint32_t i;
 	bool is_constant = 1;
-	bool use_template = true;
+	bool use_template = CG(compiler_options) & ZEND_COMPILE_WITH_ARRAY_TEMPLATES;
 
 	if (ast->attr == ZEND_ARRAY_SYNTAX_LIST) {
 		zend_error(E_COMPILE_ERROR, "Cannot use list() as standalone expression");

Zend/zend_compile.h

@@ -1285,6 +1285,11 @@ END_EXTERN_C()
 /* ignore observer notifications, e.g. to manually notify afterwards in a post-processing step after compilation */
 #define ZEND_COMPILE_IGNORE_OBSERVER			(1<<18)
 
+/* Allow compiling with ZEND_ARRAY_DUP and ZEND_ARRAY_SET_PLACEHOLDER opcodes.
+ * These are generally faster with opcache, because the array constant is
+ * immutable, which allows for fast cloning through memcpy. */
+#define ZEND_COMPILE_WITH_ARRAY_TEMPLATES		(1<<19)
+
 /* The default value for CG(compiler_options) */
 #define ZEND_COMPILE_DEFAULT					ZEND_COMPILE_HANDLE_OP_ARRAY
 

ext/opcache/ZendAccelerator.c

@@ -1815,6 +1815,7 @@ static zend_persistent_script *opcache_compile_file(zend_file_handle *file_handl
 		CG(compiler_options) |= ZEND_COMPILE_NO_CONSTANT_SUBSTITUTION;
 		CG(compiler_options) |= ZEND_COMPILE_IGNORE_OTHER_FILES;
 		CG(compiler_options) |= ZEND_COMPILE_IGNORE_OBSERVER;
+		CG(compiler_options) |= ZEND_COMPILE_WITH_ARRAY_TEMPLATES;
 #ifdef ZEND_WIN32
 		/* On Windows, don't compile with internal classes. Shm may be attached from different
 		 * processes with internal classes living in different addresses. */
@@ -4429,6 +4430,7 @@ static zend_result accel_preload(const char *config, bool in_child)
 	CG(compiler_options) |= ZEND_COMPILE_DELAYED_BINDING;
 	CG(compiler_options) |= ZEND_COMPILE_NO_CONSTANT_SUBSTITUTION;
 	CG(compiler_options) |= ZEND_COMPILE_IGNORE_OTHER_FILES;
+	CG(compiler_options) |= ZEND_COMPILE_WITH_ARRAY_TEMPLATES;
 	CG(skip_shebang) = true;
 
 	zend_try {