Implement ReflectionEnumCase::getScalar()

Author: iluuu1994

ext/reflection/php_reflection.c

@@ -88,6 +88,7 @@ PHPAPI zend_class_entry *reflection_zend_extension_ptr;
 PHPAPI zend_class_entry *reflection_reference_ptr;
 PHPAPI zend_class_entry *reflection_attribute_ptr;
 PHPAPI zend_class_entry *reflection_enum_ptr;
+PHPAPI zend_class_entry *reflection_enum_case_ptr;
 
 /* Exception throwing macro */
 #define _DO_THROW(msg) \
@@ -6496,6 +6497,28 @@ ZEND_METHOD(ReflectionEnum, getPrimitiveType)
 	}
 }
 
+ZEND_METHOD(ReflectionEnumCase, getScalar)
+{
+	reflection_object *intern;
+	zend_class_constant *ref;
+
+	if (zend_parse_parameters_none() == FAILURE) {
+		RETURN_THROWS();
+	}
+	GET_REFLECTION_OBJECT_PTR(ref);
+
+	if (Z_TYPE(ref->value) == IS_CONSTANT_AST) {
+		zval_update_constant_ex(&ref->value, ref->ce);
+	}
+
+	zend_string *value_name = zend_string_init("value", strlen("value"), 0);
+	zval rv;
+	zval *member_p = zend_read_property_ex(intern->ce, Z_OBJ(ref->value), value_name, 1, &rv);
+	zend_string_release(value_name);
+
+	ZVAL_COPY_OR_DUP(return_value, member_p);
+}
+
 /* {{{ _reflection_write_property */
 static zval *_reflection_write_property(zend_object *object, zend_string *name, zval *value, void **cache_slot)
 {
@@ -6656,6 +6679,11 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
 	_reflection_entry.ce_flags |= ZEND_ACC_FINAL;
 	reflection_enum_ptr = zend_register_internal_class_ex(&_reflection_entry, reflection_class_ptr);
 
+	INIT_CLASS_ENTRY(_reflection_entry, "ReflectionEnumCase", class_ReflectionEnumCase_methods);
+	reflection_init_class_handlers(&_reflection_entry);
+	_reflection_entry.ce_flags |= ZEND_ACC_FINAL;
+	reflection_enum_ptr = zend_register_internal_class_ex(&_reflection_entry, reflection_class_constant_ptr);
+
 	REGISTER_REFLECTION_CLASS_CONST_LONG(attribute, "IS_INSTANCEOF", REFLECTION_ATTRIBUTE_IS_INSTANCEOF);
 
 	REFLECTION_G(key_initialized) = 0;

ext/reflection/php_reflection.h

@@ -44,6 +44,7 @@ extern PHPAPI zend_class_entry *reflection_zend_extension_ptr;
 extern PHPAPI zend_class_entry *reflection_reference_ptr;
 extern PHPAPI zend_class_entry *reflection_attribute_ptr;
 extern PHPAPI zend_class_entry *reflection_enum_ptr;
+extern PHPAPI zend_class_entry *reflection_enum_case_ptr;
 
 PHPAPI void zend_reflection_class_factory(zend_class_entry *ce, zval *object);
 

ext/reflection/php_reflection.stub.php

@@ -677,3 +677,9 @@ public function hasPrimitiveType() {}
     /** @return ReflectionType|null */
     public function getPrimitiveType() {}
 }
+
+final class ReflectionEnumCase extends ReflectionClassConstant
+{
+    /** @return int|string|null */
+    public function getScalar() {}
+}

ext/reflection/php_reflection_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: e17df8167053899d826e74665993b2e0329b18ea */
+ * Stub hash: c2f68146b8e3a10808080c2a27e7710e819efeab */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0)
@@ -495,6 +495,8 @@ ZEND_END_ARG_INFO()
 
 #define arginfo_class_ReflectionEnum_getPrimitiveType arginfo_class_ReflectionFunctionAbstract_inNamespace
 
+#define arginfo_class_ReflectionEnumCase_getScalar arginfo_class_ReflectionFunctionAbstract_inNamespace
+
 
 ZEND_METHOD(Reflection, getModifierNames);
 ZEND_METHOD(ReflectionClass, __clone);
@@ -699,6 +701,7 @@ ZEND_METHOD(ReflectionAttribute, __clone);
 ZEND_METHOD(ReflectionAttribute, __construct);
 ZEND_METHOD(ReflectionEnum, hasPrimitiveType);
 ZEND_METHOD(ReflectionEnum, getPrimitiveType);
+ZEND_METHOD(ReflectionEnumCase, getScalar);
 
 
 static const zend_function_entry class_ReflectionException_methods[] = {
@@ -1011,3 +1014,9 @@ static const zend_function_entry class_ReflectionEnum_methods[] = {
 	ZEND_ME(ReflectionEnum, getPrimitiveType, arginfo_class_ReflectionEnum_getPrimitiveType, ZEND_ACC_PUBLIC)
 	ZEND_FE_END
 };
+
+
+static const zend_function_entry class_ReflectionEnumCase_methods[] = {
+	ZEND_ME(ReflectionEnumCase, getScalar, arginfo_class_ReflectionEnumCase_getScalar, ZEND_ACC_PUBLIC)
+	ZEND_FE_END
+};

ext/reflection/tests/ReflectionEnumCase_getScalar.phpt

@@ -0,0 +1,26 @@
+--TEST--
+ReflectionEnumCase::getScalar()
+--FILE--
+<?php
+
+enum Enum_ {
+    case Foo;
+}
+
+enum IntEnum: int {
+    case Foo = 0;
+}
+
+enum StringEnum: string {
+    case Foo = 'Foo';
+}
+
+var_dump((new ReflectionEnumCase(Enum_::class, 'Foo'))->getScalar());
+var_dump((new ReflectionEnumCase(IntEnum::class, 'Foo'))->getScalar());
+var_dump((new ReflectionEnumCase(StringEnum::class, 'Foo'))->getScalar());
+
+?>
+--EXPECT--
+NULL
+int(0)
+string(3) "Foo"

ext/reflection/tests/ReflectionExtension_getClasses_basic.phpt

@@ -8,7 +8,7 @@ $ext = new ReflectionExtension('reflection');
 var_dump($ext->getClasses());
 ?>
 --EXPECT--
-array(20) {
+array(21) {
   ["ReflectionException"]=>
   object(ReflectionClass)#2 (1) {
     ["name"]=>
@@ -109,4 +109,9 @@ array(20) {
     ["name"]=>
     string(14) "ReflectionEnum"
   }
+  ["ReflectionEnumCase"]=>
+  object(ReflectionClass)#22 (1) {
+    ["name"]=>
+    string(18) "ReflectionEnumCase"
+  }
 }