following up.

Author: devnexen

ext/sockets/sockets.c

@@ -368,9 +368,14 @@ char *sockets_strerror(int error) /* {{{ */
 {
 	const char *buf;
 
+	ZEND_ASSERT(error >= INT_MIN);
 #ifndef PHP_WIN32
 	if (error < -10000) {
-		error = -error - 10000;
+		if (error == INT_MIN) {
+			error = 2147473648;
+		} else {
+			error = -error - 10000;
+		}
 
 #ifdef HAVE_HSTRERROR
 		buf = hstrerror(error);
@@ -1248,8 +1253,8 @@ PHP_FUNCTION(socket_strerror)
 		Z_PARAM_LONG(arg1)
 	ZEND_PARSE_PARAMETERS_END();
 
-	if (arg1 <= INT_MIN || arg1 > INT_MAX) {
-		zend_argument_value_error(1, "must be between %d and %d", (INT_MIN + 1), INT_MAX);
+	if (ZEND_LONG_EXCEEDS_INT(arg1)) {
+		zend_argument_value_error(1, "must be between %d and %d", INT_MIN, INT_MAX);
 		RETURN_THROWS();
 	}
 

ext/sockets/tests/gh16267.phpt

@@ -6,17 +6,13 @@ sockets
 <?php if (PHP_INT_SIZE != 8) die("skip this test is for 64bit platform only"); ?>
 --FILE--
 <?php
-try {
-	socket_strerror(-2147483648);
-} catch (\ValueError $e) {
-	echo $e->getMessage() . PHP_EOL;
-}
+var_dump(socket_strerror(-2147483648));
 try {
 	socket_strerror(2147483648);
 } catch (\ValueError $e) {
 	echo $e->getMessage() . PHP_EOL;
 }
 ?>
 --EXPECTF--
-socket_strerror(): Argument #1 ($error_code) must be between %s and %d
-socket_strerror(): Argument #1 ($error_code) must be between %s and %d
+string(22) "Unknown resolver error"
+socket_strerror(): Argument #1 ($error_code) must be between %i and %d