Unsuccessful attempt to fix the namespace issue.

Author: Crell

Zend/tests/pipe_operator/namespaced_functions.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Functions in namespaces can be piped
+--FILE--
+<?php
+
+namespace Beep {
+  function test(int $x) {
+    print $x;
+  }
+}
+
+namespace Bar {
+    use function \Beep\test;
+
+    5 |> test(...);
+}
+
+?>
+--EXPECT--
+5

Zend/zend_compile.c

@@ -6417,23 +6417,26 @@ static void zend_compile_pipe(znode *result, zend_ast *ast)
 	zend_ast *operand_ast = ast->child[0];
 	zend_ast *callable_ast = ast->child[1];
 
+	// Execute everything on the left side first, down to a value.
 	znode operand_result;
 	zend_compile_expr(&operand_result, operand_ast);
+
+	// Wrap the operand in a ZEND_QM_ASSIGN to prevent references
+	// from working in all cases. (Otherwise they'd fail only in some.)
 	znode wrapped_operand_result;
 	zend_emit_op_tmp(&wrapped_operand_result, ZEND_QM_ASSIGN, &operand_result, NULL);
 
-	/* Turn $foo |> bar(...) into bar($foo). */
+	// Turn $foo |> bar(...) into bar($foo).
 	if (callable_ast->kind == ZEND_AST_CALL
 	    && callable_ast->child[1]->kind == ZEND_AST_CALLABLE_CONVERT) {
 		callable_ast = callable_ast->child[0];
+	} else {
+		znode callable_result;
+		callable_ast = zend_ast_create_znode(&callable_result);
+		zend_compile_expr(&callable_result, callable_ast);
 	}
 
-	znode callable_result;
-	zend_compile_expr(&callable_result, callable_ast);
-
-	zend_ast *fcall_ast = zend_ast_create(ZEND_AST_CALL,
-	                                      zend_ast_create_znode(&callable_result),
-	                                      zend_ast_create_list(1, ZEND_AST_ARG_LIST, zend_ast_create_znode(&wrapped_operand_result)));
+	zend_ast *fcall_ast = zend_ast_create_list(1, ZEND_AST_ARG_LIST, zend_ast_create_znode(&wrapped_operand_result));
 
 	zend_compile_expr(result, fcall_ast);
 }