Skip to content

Commit 82143e0

Browse files
committed
libxml test fixes
1 parent 5511351 commit 82143e0

File tree

4 files changed

+18
-36
lines changed

4 files changed

+18
-36
lines changed

ext/libxml/tests/001.phpt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ libxml_use_internal_errors()
88
var_dump(libxml_use_internal_errors(false));
99
var_dump(libxml_use_internal_errors(true));
1010
var_dump(libxml_use_internal_errors());
11-
var_dump(libxml_use_internal_errors(new stdclass));
1211

1312
var_dump(libxml_get_errors());
1413
var_dump(libxml_get_last_error());
@@ -17,13 +16,10 @@ var_dump(libxml_clear_errors());
1716

1817
echo "Done\n";
1918
?>
20-
--EXPECTF--
19+
--EXPECT--
2120
bool(false)
2221
bool(false)
2322
bool(true)
24-
25-
Warning: libxml_use_internal_errors() expects parameter 1 to be bool, object given in %s001.php on line 6
26-
NULL
2723
array(0) {
2824
}
2925
bool(false)

ext/libxml/tests/004.phpt

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ $ctxs = array(
1818

1919

2020
foreach ($ctxs as $ctx) {
21-
var_dump(libxml_set_streams_context($ctx));
21+
try {
22+
var_dump(libxml_set_streams_context($ctx));
23+
} catch (TypeError $e) {
24+
echo $e->getMessage(), "\n";
25+
}
2226
$dom = new DOMDocument();
2327
var_dump($dom->load(dirname(__FILE__).'/test.xml'));
2428
}
@@ -28,25 +32,15 @@ echo "Done\n";
2832
?>
2933
--EXPECTF--
3034
Warning: stream_context_create(): options should have the form ["wrappername"]["optionname"] = $value in %s004.php on line %d
31-
32-
Warning: libxml_set_streams_context() expects parameter 1 to be resource, null given in %s004.php on line %d
33-
NULL
35+
libxml_set_streams_context() expects parameter 1 to be resource, null given
3436
bool(true)
35-
36-
Warning: libxml_set_streams_context() expects parameter 1 to be resource, string given in %s004.php on line %d
37-
NULL
37+
libxml_set_streams_context() expects parameter 1 to be resource, string given
3838
bool(true)
39-
40-
Warning: libxml_set_streams_context() expects parameter 1 to be resource, int given in %s004.php on line %d
41-
NULL
39+
libxml_set_streams_context() expects parameter 1 to be resource, int given
4240
bool(true)
43-
44-
Warning: libxml_set_streams_context() expects parameter 1 to be resource, object given in %s004.php on line %d
45-
NULL
41+
libxml_set_streams_context() expects parameter 1 to be resource, object given
4642
bool(true)
47-
48-
Warning: libxml_set_streams_context() expects parameter 1 to be resource, array given in %s004.php on line %d
49-
NULL
43+
libxml_set_streams_context() expects parameter 1 to be resource, array given
5044
bool(true)
5145
NULL
5246
bool(true)

ext/libxml/tests/bug63389.phpt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,13 @@ Bug #63389 (Missing context check on libxml_set_streams_context() causes memleak
66
<?php
77
$fp = fopen("php://input", "r");
88
libxml_set_streams_context($fp);
9-
libxml_set_streams_context("a");
9+
try {
10+
libxml_set_streams_context("a");
11+
} catch (TypeError $e) {
12+
echo $e->getMessage(), "\n";
13+
}
1014
echo "okey";
1115
?>
12-
--EXPECTF--
13-
Warning: libxml_set_streams_context() expects parameter 1 to be resource, string given in %sbug63389.php on line %d
16+
--EXPECT--
17+
libxml_set_streams_context() expects parameter 1 to be resource, string given
1418
okey

ext/libxml/tests/libxml_set_external_entity_loader_error1.phpt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ XML;
1212
$dd = new DOMDocument;
1313
$r = $dd->loadXML($xml);
1414

15-
var_dump(libxml_set_external_entity_loader([]));
16-
var_dump(libxml_set_external_entity_loader());
17-
var_dump(libxml_set_external_entity_loader(function() {}, 2));
18-
1915
var_dump(libxml_set_external_entity_loader(function($a, $b, $c, $d) {}));
2016
try {
2117
var_dump($dd->validate());
@@ -25,14 +21,6 @@ try {
2521

2622
echo "Done.\n";
2723
--EXPECTF--
28-
Warning: libxml_set_external_entity_loader() expects parameter 1 to be a valid callback, array must have exactly two members in %s on line %d
29-
NULL
30-
31-
Warning: libxml_set_external_entity_loader() expects exactly 1 parameter, 0 given in %s on line %d
32-
NULL
33-
34-
Warning: libxml_set_external_entity_loader() expects exactly 1 parameter, 2 given in %s on line %d
35-
NULL
3624
bool(true)
3725

3826
Warning: DOMDocument::validate(): Could not load the external subset "http://example.com/foobar" in %s on line %d

0 commit comments

Comments
 (0)