Update tests; tweak comments

Author: DanielEScherzer

Zend/tests/attributes/delayed_target_validation/errors_from_validator.phpt

@@ -20,10 +20,6 @@ readonly class DemoReadonly {}
 enum DemoEnum {}
 
 class DemoClass {
-	#[DelayedTargetValidation]
-	#[NoDiscard] // Does nothing here
-	public $val;
-
 	public string $hooked {
 		#[DelayedTargetValidation]
 		#[NoDiscard] // Does nothing here
@@ -88,7 +84,7 @@ array(2) {
     string(22) "AllowDynamicProperties"
   }
 }
-Error: Cannot apply #[AllowDynamicProperties] to trait DemoTrait
+Error: Cannot apply #[\AllowDynamicProperties] to trait DemoTrait
 ********************
 Interface [ <user> interface DemoInterface ] {
   @@ %s %d-%d
@@ -121,7 +117,7 @@ array(2) {
     string(22) "AllowDynamicProperties"
   }
 }
-Error: Cannot apply #[AllowDynamicProperties] to interface DemoInterface
+Error: Cannot apply #[\AllowDynamicProperties] to interface DemoInterface
 ********************
 Class [ <user> readonly class DemoReadonly ] {
   @@ %s %d-%d
@@ -154,7 +150,7 @@ array(2) {
     string(22) "AllowDynamicProperties"
   }
 }
-Error: Cannot apply #[AllowDynamicProperties] to readonly class DemoReadonly
+Error: Cannot apply #[\AllowDynamicProperties] to readonly class DemoReadonly
 ********************
 Enum [ <user> enum DemoEnum implements UnitEnum ] {
   @@ %s %d-%d
@@ -194,7 +190,7 @@ array(2) {
     string(22) "AllowDynamicProperties"
   }
 }
-Error: Cannot apply #[AllowDynamicProperties] to enum DemoEnum
+Error: Cannot apply #[\AllowDynamicProperties] to enum DemoEnum
 ********************
 Method [ <user> public method $hooked::get ] {
   @@ %s %d - %d

Zend/tests/attributes/delayed_target_validation/has_runtime_errors.phpt

@@ -88,7 +88,7 @@ Class [ <user> <iterateable> class Demo ] {
 
   - Properties [3] {
     Property [ public string $v1 ]
-    Property [ public string $v2 ]
+    Property [ public string $v2 { get; set; } ]
     Property [ public string $v3 ]
   }
 

Zend/tests/attributes/delayed_target_validation/with_NoDiscard.phpt

@@ -57,7 +57,7 @@ $v = $d->printVal();
 var_dump($d->val);
 $d->hooked = "foo";
 var_dump($d->hooked);
-// NODiscard does not support property hooks, this should not complain
+// NoDiscard does not support property hooks, this should not complain
 $d->hooked;
 var_dump(DemoClass::CLASS_CONST);
 demoFn();

Zend/zend_attributes.c

@@ -74,9 +74,9 @@ static void validate_allow_dynamic_properties(
 		zend_attribute *attr, uint32_t target, zend_class_entry *scope)
 {
 	if (scope == NULL) {
-		// Only reachable when validator is run but the attribute isn't applied
-		// to a class; in the case of delayed target validation reflection will
-		// complain about the target before running the validator;
+		/* Only reachable when validator is run but the attribute isn't applied
+		 * to a class; in the case of delayed target validation reflection will
+		 * complain about the target before running the validator. */
 		ZEND_ASSERT(target & ZEND_ATTRIBUTE_NO_TARGET_VALIDATION);
 		return;
 	}
@@ -215,8 +215,7 @@ static void validate_nodiscard(
 {
 	/* There isn't an easy way to identify the *method* that the attribute is
 	 * applied to in a manner that works during both compilation (normal
-	 * validation) and runtime (delayed validation). So, handle them separately.
-	 */
+	 * validation) and runtime (delayed validation). So, handle them separately. */
 	if (CG(in_compilation)) {
 		ZEND_ASSERT((target & ZEND_ATTRIBUTE_DELAYED_TARGET_VALIDATION) == 0);
 		zend_op_array *op_array = CG(active_op_array);