apply suggestion

Author: devnexen

ext/standard/pack.c

@@ -388,13 +388,7 @@ PHP_FUNCTION(pack)
 		switch ((int) code) {
 			case 'h':
 			case 'H':
-				if (arg == INT_MAX) {
-					efree(formatcodes);
-					efree(formatargs);
-					zend_value_error("Type %c: integer overflow in format string", code);
-					RETURN_THROWS();
-				}
-				INC_OUTPUTPOS((arg + (arg % 2)) / 2,1)	/* 4 bit per arg */
+				INC_OUTPUTPOS((arg / 2) + (arg % 2),1)	/* 4 bit per arg */
 				break;
 
 			case 'a':

ext/standard/tests/strings/gh18976.phpt

@@ -1,18 +1,14 @@
 --TEST--
 GH-18976 pack overflow wit h/H format
+--INI--
+memory_limit=-1
 --FILE--
 <?php
-try {
-	pack('h2147483647', 1);
-} catch (ValueError $e) {
-	echo $e->getMessage(), PHP_EOL;
-}
-try {
-	pack('H2147483647', 1);
-} catch (ValueError $e) {
-	echo $e->getMessage(), PHP_EOL;
-}
+pack('h2147483647', 1);
+pack('H2147483647', 1);
 ?>
---EXPECT--
-Type h: integer overflow in format string
-Type H: integer overflow in format string
+--EXPECTF--
+
+Warning: pack(): Type h: not enough characters in string in %s on line %d
+
+Warning: pack(): Type H: not enough characters in string in %s on line %d