Skip to content

Commit 84e1262

Browse files
committed
Use zend_string_equals() API instead of strcmp() in SOAP extension
1 parent ddfe269 commit 84e1262

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ext/soap/php_http.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ int make_http_soap_request(zval *this_ptr,
491491
(((use_ssl && orig->scheme != NULL && zend_string_equals_literal(orig->scheme, "https")) ||
492492
(!use_ssl && orig->scheme == NULL) ||
493493
(!use_ssl && !zend_string_equals_literal(orig->scheme, "https"))) &&
494-
strcmp(ZSTR_VAL(orig->host), ZSTR_VAL(phpurl->host)) == 0 &&
494+
zend_string_equals(orig->host, phpurl->host) &&
495495
orig->port == phpurl->port))) {
496496
} else {
497497
php_stream_close(stream);

ext/soap/soap.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,9 +1275,9 @@ PHP_METHOD(SoapServer, handle)
12751275
(encoding = zend_hash_str_find(Z_ARRVAL_P(server_vars), "HTTP_CONTENT_ENCODING", sizeof("HTTP_CONTENT_ENCODING")-1)) != NULL &&
12761276
Z_TYPE_P(encoding) == IS_STRING) {
12771277

1278-
if (strcmp(Z_STRVAL_P(encoding),"gzip") == 0
1279-
|| strcmp(Z_STRVAL_P(encoding),"x-gzip") == 0
1280-
|| strcmp(Z_STRVAL_P(encoding),"deflate") == 0
1278+
if (zend_string_equals_literal(Z_STR_P(encoding), "gzip")
1279+
|| zend_string_equals_literal(Z_STR_P(encoding), "x-gzip")
1280+
|| zend_string_equals_literal(Z_STR_P(encoding), "deflate")
12811281
) {
12821282
zval filter_params;
12831283

0 commit comments

Comments
 (0)