Review feedback

DanielEScherzer · DanielEScherzer · commit 85a626927a52 · 2025-09-05T16:01:30.000+03:00
diff --git a/Zend/tests/attributes/constants/constant_listed_as_target-internal.phpt b/Zend/tests/attributes/constants/constant_listed_as_target-internal.phpt
@@ -3,7 +3,6 @@ Constants listed in valid targets when used wrong (internal attribute)
 --FILE--
 <?php
 
-#[Deprecated]
 function demo(
 	#[Deprecated] $v
 ) {}
diff --git a/Zend/tests/attributes/delayed_target_validation/validator_Deprecated.phpt b/Zend/tests/attributes/delayed_target_validation/validator_Deprecated.phpt
@@ -66,7 +66,7 @@ array(2) {
     string(10) "Deprecated"
   }
 }
-Error: Cannot apply #[Deprecated] to interface DemoInterface
+Error: Cannot apply #[\Deprecated] to interface DemoInterface
 ********************
 Class [ <user> class DemoClass ] {
   @@ %s %d-%d
@@ -99,7 +99,7 @@ array(2) {
     string(10) "Deprecated"
   }
 }
-Error: Cannot apply #[Deprecated] to class DemoClass
+Error: Cannot apply #[\Deprecated] to class DemoClass
 ********************
 Enum [ <user> enum DemoEnum implements UnitEnum ] {
   @@ %s %d-%d
@@ -139,4 +139,4 @@ array(2) {
     string(10) "Deprecated"
   }
 }
-Error: Cannot apply #[Deprecated] to enum DemoEnum
+Error: Cannot apply #[\Deprecated] to enum DemoEnum
diff --git a/Zend/tests/attributes/deprecated/error_on_class.phpt b/Zend/tests/attributes/deprecated/error_on_class.phpt
@@ -8,4 +8,4 @@ class Demo {}
 
 ?>
 --EXPECTF--
-Fatal error: Cannot apply #[Deprecated] to class Demo in %s on line %d
+Fatal error: Cannot apply #[\Deprecated] to class Demo in %s on line %d
diff --git a/Zend/tests/attributes/deprecated/error_on_enum.phpt b/Zend/tests/attributes/deprecated/error_on_enum.phpt
@@ -8,4 +8,4 @@ enum Demo {}
 
 ?>
 --EXPECTF--
-Fatal error: Cannot apply #[Deprecated] to enum Demo in %s on line %d
+Fatal error: Cannot apply #[\Deprecated] to enum Demo in %s on line %d
diff --git a/Zend/tests/attributes/deprecated/error_on_interface.phpt b/Zend/tests/attributes/deprecated/error_on_interface.phpt
@@ -8,4 +8,4 @@ interface Demo {}
 
 ?>
 --EXPECTF--
-Fatal error: Cannot apply #[Deprecated] to interface Demo in %s on line %d
+Fatal error: Cannot apply #[\Deprecated] to interface Demo in %s on line %d
diff --git a/Zend/zend_attributes.c b/Zend/zend_attributes.c
@@ -121,7 +121,7 @@ static zend_string *validate_deprecated(
 	}
 	if (!(scope->ce_flags & ZEND_ACC_TRAIT)) {
 		const char *type = zend_get_object_type_case(scope, false);
-		return zend_strpprintf(0, "Cannot apply #[Deprecated] to %s %s", type, ZSTR_VAL(scope->name));
+		return zend_strpprintf(0, "Cannot apply #[\\Deprecated] to %s %s", type, ZSTR_VAL(scope->name));
 	}
 
 	scope->ce_flags |= ZEND_ACC_DEPRECATED;

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ array(2) {`
`66`	`66`	`string(10) "Deprecated"`
`67`	`67`	`}`
`68`	`68`	`}`
`69`		`-Error: Cannot apply #[Deprecated] to interface DemoInterface`
	`69`	`+Error: Cannot apply #[\Deprecated] to interface DemoInterface`
`70`	`70`	`********************`
`71`	`71`	`Class [ <user> class DemoClass ] {`
`72`	`72`	`@@ %s %d-%d`
`@@ -99,7 +99,7 @@ array(2) {`
`99`	`99`	`string(10) "Deprecated"`
`100`	`100`	`}`
`101`	`101`	`}`
`102`		`-Error: Cannot apply #[Deprecated] to class DemoClass`
	`102`	`+Error: Cannot apply #[\Deprecated] to class DemoClass`
`103`	`103`	`********************`
`104`	`104`	`Enum [ <user> enum DemoEnum implements UnitEnum ] {`
`105`	`105`	`@@ %s %d-%d`
`@@ -139,4 +139,4 @@ array(2) {`
`139`	`139`	`string(10) "Deprecated"`
`140`	`140`	`}`
`141`	`141`	`}`
`142`		`-Error: Cannot apply #[Deprecated] to enum DemoEnum`
	`142`	`+Error: Cannot apply #[\Deprecated] to enum DemoEnum`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ static zend_string *validate_deprecated(`
`121`	`121`	`}`
`122`	`122`	`if (!(scope->ce_flags & ZEND_ACC_TRAIT)) {`
`123`	`123`	`const char *type = zend_get_object_type_case(scope, false);`
`124`		`- return zend_strpprintf(0, "Cannot apply #[Deprecated] to %s %s", type, ZSTR_VAL(scope->name));`
	`124`	`+ return zend_strpprintf(0, "Cannot apply #[\\Deprecated] to %s %s", type, ZSTR_VAL(scope->name));`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`scope->ce_flags \|= ZEND_ACC_DEPRECATED;`