opcache: file_cache_read_only code review update 4 (#16484)

iamacarpet · iamacarpet · commit 8c43a771ac53 · 2024-10-25T21:43:58.000Z
diff --git a/UPGRADING b/UPGRADING
@@ -105,6 +105,10 @@ PHP 8.5 UPGRADE NOTES
     readline_callback_handler_install() have been changed to true, rather
     than bool.
 
+- opcache:
+  . Introduce opcache.file_cache_read_only to support a read-only
+    opcache.file_cache directory, for use with read-only Docker containers.
+
 ========================================
 10. New Global Constants
 ========================================
diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c
@@ -3329,7 +3329,7 @@ static zend_result accel_post_startup(void)
 #endif
 	}
 
-	if ( ZCG(accel_directives).file_cache ){
+	if ( ZCG(accel_directives).file_cache ) {
 		zend_stat_t buf = {0};
 
 		if (!IS_ABSOLUTE_PATH(ZCG(accel_directives).file_cache, strlen(ZCG(accel_directives).file_cache)) ||

Original file line number	Diff line number	Diff line change
`@@ -3329,7 +3329,7 @@ static zend_result accel_post_startup(void)`
`3329`	`3329`	`#endif`
`3330`	`3330`	`}`
`3331`	`3331`
`3332`		`- if ( ZCG(accel_directives).file_cache ){`
	`3332`	`+ if ( ZCG(accel_directives).file_cache ) {`
`3333`	`3333`	`zend_stat_t buf = {0};`
`3334`	`3334`
`3335`	`3335`	`if (!IS_ABSOLUTE_PATH(ZCG(accel_directives).file_cache, strlen(ZCG(accel_directives).file_cache)) \|\|`