Commit 9079d61
committed
ext/iconv/tests/bug48147.phpt: rename and repurpose
This test ensures that iconv() with //IGNORE will return part of the
translated string when it is given invalid inputs. POSIX and the PHP
documentation however agree that an error should be returned in that
case: the test is making sure that we get the wrong answer.
PHP's iconv has recently been updated to agree with the standard and
docs. As a result, this test fails, but that's OK -- it should. The
history of iconv in PHP is convoluted, so rather than just update the
expected output here, I think it's best to rename the test and sever
its ties to bug 48147. Referencing that bug at this point can only
cause confusion.1 parent 0535da4 commit 9079d61
File tree
2 files changed
+42
-27
lines changed- ext/iconv/tests
2 files changed
+42
-27
lines changedThis file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
0 commit comments