Skip to content

Commit 90a806a

Browse files
committed
Address review comments
1 parent 148f98d commit 90a806a

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

Zend/zend_exceptions.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,6 @@ static void _build_trace_string(smart_str *str, const HashTable *ht, uint32_t nu
540540
file = zend_hash_find_known_hash(ht, ZSTR_KNOWN(ZEND_STR_FILE));
541541
if (file) {
542542
if (UNEXPECTED(Z_TYPE_P(file) != IS_STRING)) {
543-
/* This is a typed property and can only happen if modified via ArrayObject */
544543
zend_error(E_WARNING, "File name is not a string");
545544
smart_str_appends(str, "[unknown file]: ");
546545
} else{
@@ -550,7 +549,6 @@ static void _build_trace_string(smart_str *str, const HashTable *ht, uint32_t nu
550549
if (EXPECTED(Z_TYPE_P(tmp) == IS_LONG)) {
551550
line = Z_LVAL_P(tmp);
552551
} else {
553-
/* This is a typed property and can only happen if modified via ArrayObject */
554552
zend_error(E_WARNING, "Line is not an int");
555553
}
556554
}
@@ -585,7 +583,6 @@ static void _build_trace_string(smart_str *str, const HashTable *ht, uint32_t nu
585583
ZSTR_LEN(str->s) -= 2; /* remove last ', ' */
586584
}
587585
} else {
588-
/* The trace property is typed and private */
589586
zend_error(E_WARNING, "args element is not an array");
590587
}
591588
}

0 commit comments

Comments
 (0)