feat: add share options as class property

Notably, I needed to expose php_array_data_compare_unstable_i, in order
to avoid re-implementing a comparison function. ext/intl/collator_sort.c
chose to copy the implementation, and could maybe benefit from using
the exposed function instead.

Author: ericnorris

ext/curl/curl.stub.php

@@ -3674,6 +3674,7 @@ final class CurlShareHandle
  */
 final class CurlPersistentShareHandle
 {
+    public readonly array $options;
 }
 
 function curl_close(CurlHandle $handle): void {}

ext/curl/curl_arginfo.h

@@ -21,6 +21,7 @@
 #endif
 
 #include "php.h"
+#include "ext/standard/php_array.h"
 #include "Zend/zend_exceptions.h"
 
 #include "curl_private.h"
@@ -150,7 +151,7 @@ PHP_FUNCTION(curl_persistent_share_init)
 	CURLSHcode error;
 
 	ZEND_PARSE_PARAMETERS_START(1, 1)
-		Z_PARAM_ARRAY(share_opts)
+		Z_PARAM_ARRAY_EX(share_opts, 0, 1)
 	ZEND_PARSE_PARAMETERS_END();
 
 	object_init_ex(return_value, curl_persistent_share_ce);
@@ -175,6 +176,9 @@ PHP_FUNCTION(curl_persistent_share_init)
 		persistent_id += 1 << option;
 	} ZEND_HASH_FOREACH_END();
 
+	zend_array_sort(Z_ARRVAL_P(share_opts), php_array_data_compare_unstable_i, 1);
+	zend_update_property(curl_persistent_share_ce, Z_OBJ_P(return_value), "options", sizeof("options") - 1, share_opts);
+
 	if (persistent_id) {
 		zval *persisted = zend_hash_index_find(&CURL_G(persistent_curlsh), persistent_id);
 

ext/curl/share.c

@@ -283,7 +283,7 @@ static zend_always_inline int php_array_key_compare_string_locale_unstable_i(Buc
 }
 /* }}} */
 
-static zend_always_inline int php_array_data_compare_unstable_i(Bucket *f, Bucket *s) /* {{{ */
+PHPAPI zend_always_inline int php_array_data_compare_unstable_i(Bucket *f, Bucket *s) /* {{{ */
 {
 	int result = zend_compare(&f->val, &s->val);
 	/* Special enums handling for array_unique. We don't want to add this logic to zend_compare as

ext/standard/array.c

@@ -28,6 +28,7 @@ PHP_MSHUTDOWN_FUNCTION(array);
 PHPAPI int php_array_merge(HashTable *dest, HashTable *src);
 PHPAPI int php_array_merge_recursive(HashTable *dest, HashTable *src);
 PHPAPI int php_array_replace_recursive(HashTable *dest, HashTable *src);
+PHPAPI int php_array_data_compare_unstable_i(Bucket *f, Bucket *s);
 PHPAPI int php_multisort_compare(const void *a, const void *b);
 PHPAPI zend_long php_count_recursive(HashTable *ht);