forgotten test and fix bugs

Author: devnexen

ext/sockets/sockets.c

@@ -2319,9 +2319,17 @@ PHP_FUNCTION(socket_set_option)
 			zend_object *so_splice_obj = Z_OBJ_P(arg4);
 			zval tmpA, tmpB, tmpC;
 
-			zval *socket = zend_read_property(socket_so_splice_ce, so_splice_obj, "socket", strlen("socket"), 0, &tmpA);
-			zval *max = zend_read_property(socket_so_splice_ce, so_splice_obj, "max", strlen("max"), 0, &tmpB);
-			zval *array = zend_read_property(socket_so_splice_ce, so_splice_obj, "time", strlen("time"), 0, &tmpC);
+			zval *socket = zend_read_property(socket_so_splice_ce, so_splice_obj, "socket", strlen("socket"), false, &tmpA);
+			if (Z_TYPE_P(socket) == IS_NULL) {
+					zend_argument_type_error(4, "invalid SocketSoSplice socket member value");
+					RETURN_THROWS();
+			}
+			zval *max = zend_read_property(socket_so_splice_ce, so_splice_obj, "max", strlen("max"), false, &tmpB);
+			zval *array = zend_read_property(socket_so_splice_ce, so_splice_obj, "time", strlen("time"), false, &tmpC);
+			if (Z_TYPE_P(array) == IS_NULL) {
+					zend_argument_type_error(4, "invalid SocketSoSplice time member value");
+					RETURN_THROWS();
+			}
 
 			php_socket *php_sock = Z_SOCKET_P(socket);
 			zend_long php_max = Z_LVAL_P(max);

ext/sockets/tests/socket_set_option_so_splice.phpt

@@ -0,0 +1,47 @@
+--TEST--
+SO_SPLICE usage with socket_set_option
+--EXTENSIONS--
+sockets
+--SKIPIF--
+<?php
+
+if (!defined('SO_SPLICE')) {
+    die('skip SO_SPLICE not available.');
+}
+
+?>
+--FILE--
+<?php
+class badClass {}
+$socket = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
+$todrain = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
+
+try {
+	socket_set_option($socket, SOL_SOCKET, SO_SPLICE, $todrain);
+} catch (\TypeError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
+
+try {
+	socket_set_option($socket, SOL_SOCKET, SO_SPLICE, new badClass());
+} catch (\TypeError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
+
+try {
+	$s = new SocketSoSplice();
+	$s->max = -1;
+	$s->socket = $todrain;
+	$s->time = ["sec" => 0, "usec" => 0];
+	socket_set_option($socket, SOL_SOCKET, SO_SPLICE, $s);
+} catch (\ValueError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
+
+socket_close($todrain);
+socket_close($socket);
+?>
+--EXPECT--
+socket_set_option(): Argument #4 ($value) must be of type SocketSoSplice, Socket given
+socket_set_option(): Argument #4 ($value) must be of type SocketSoSplice, badClass given
+socket_set_option(): Argument #4 ($value) "max" key must be greater than or equal to 0