Add comment about strict type handling for op overloading

Girgias · Girgias · commit 9fd19a932ca3 · 2024-11-16T16:44:53.000Z
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
@@ -129,6 +129,9 @@ static bool gmp_zend_parse_arg_into_mpz_ex(
 		return true;
 	}
 
+	/* This function is also used by the do_operation object hook,
+	 * but operator overloading with objects should behave as if a
+	 * method was called, thus strict types should apply. */
 	if (!ZEND_ARG_USES_STRICT_TYPES()) {
 		zend_long lval = 0;
 		if (is_operator && Z_TYPE_P(arg) == IS_NULL) {

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,9 @@ static bool gmp_zend_parse_arg_into_mpz_ex(`
`129`	`129`	`return true;`
`130`	`130`	`}`
`131`	`131`
	`132`	`+ /* This function is also used by the do_operation object hook,`
	`133`	`+ * but operator overloading with objects should behave as if a`
	`134`	`+ * method was called, thus strict types should apply. */`
`132`	`135`	`if (!ZEND_ARG_USES_STRICT_TYPES()) {`
`133`	`136`	`zend_long lval = 0;`
`134`	`137`	`if (is_operator && Z_TYPE_P(arg) == IS_NULL) {`