fix and update tests.

Author: devnexen

ext/posix/posix.c

@@ -126,9 +126,9 @@ ZEND_GET_MODULE(posix)
 	}	\
 	RETURN_TRUE;
 
-#define PHP_POSIX_CHECK_PID(pid, lower, upper)										\
+#define PHP_POSIX_CHECK_PID(pid, arg, lower, upper)										\
 	if (pid < lower || pid > upper) {										\
-		zend_argument_value_error(1, "must be between " ZEND_LONG_FMT " and " ZEND_LONG_FMT, lower, upper);	\
+		zend_argument_value_error(arg, "must be between " ZEND_LONG_FMT " and " ZEND_LONG_FMT, lower, upper);	\
 		RETURN_THROWS();											\
 	}
 
@@ -143,7 +143,7 @@ PHP_FUNCTION(posix_kill)
 		Z_PARAM_LONG(sig)
 	ZEND_PARSE_PARAMETERS_END();
 
-	PHP_POSIX_CHECK_PID(pid, POSIX_PID_MIN, POSIX_PID_MAX)
+	PHP_POSIX_CHECK_PID(pid, 1, POSIX_PID_MIN, POSIX_PID_MAX)
 
 	if (kill(pid, sig) < 0) {
 		POSIX_G(last_error) = errno;
@@ -307,8 +307,8 @@ PHP_FUNCTION(posix_setpgid)
 		Z_PARAM_LONG(pgid)
 	ZEND_PARSE_PARAMETERS_END();
 
-	PHP_POSIX_CHECK_PID(pid, 0, POSIX_PID_MAX)
-	PHP_POSIX_CHECK_PID(pgid, 0, POSIX_PID_MAX)
+	PHP_POSIX_CHECK_PID(pid, 1, 0, POSIX_PID_MAX)
+	PHP_POSIX_CHECK_PID(pgid, 2, 0, POSIX_PID_MAX)
 
 	if (setpgid(pid, pgid) < 0) {
 		POSIX_G(last_error) = errno;
@@ -348,7 +348,7 @@ PHP_FUNCTION(posix_getsid)
 		Z_PARAM_LONG(val)
 	ZEND_PARSE_PARAMETERS_END();
 
-	PHP_POSIX_CHECK_PID(val, 0, POSIX_PID_MAX)
+	PHP_POSIX_CHECK_PID(val, 1, 0, POSIX_PID_MAX)
 
 	if ((val = getsid(val)) < 0) {
 		POSIX_G(last_error) = errno;
@@ -1219,7 +1219,7 @@ PHP_FUNCTION(posix_setrlimit)
 		RETURN_THROWS();
 	}
 
-	if (cur > max) {
+	if (max > -1 && cur > max) {
 		zend_argument_value_error(2, "must be lower or equal to " ZEND_LONG_FMT, max);
 		RETURN_THROWS();
 	}

ext/posix/tests/posix_getsid_error.phpt

@@ -9,7 +9,11 @@ PHP Testfest Berlin 2009-05-10
 posix
 --FILE--
 <?php
-var_dump( posix_getsid(-1) );
+try {
+	posix_getsid(-1);
+} catch (\ValueError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
 ?>
---EXPECT--
-bool(false)
+--EXPECTF--
+posix_getsid(): Argument #1 ($process_id) must be between 0 and %d

ext/posix/tests/posix_setpgid_error.phpt

@@ -16,7 +16,19 @@ try {
 } catch (\ValueError $e) {
 	echo $e->getMessage(), PHP_EOL;
 }
+try {
+	posix_setpgid(1, PHP_INT_MAX);
+} catch (\ValueError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
+try {
+	posix_setpgid(1, -2);
+} catch (\ValueError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
 ?>
 --EXPECTF--
 posix_setpgid(): Argument #1 ($process_id) must be between 0 and %d
 posix_setpgid(): Argument #1 ($process_id) must be between 0 and %d
+posix_setpgid(): Argument #2 ($process_group_id) must be between 0 and %d
+posix_setpgid(): Argument #2 ($process_group_id) must be between 0 and %d

ext/posix/tests/posix_setrlimit.phpt

@@ -12,9 +12,13 @@ if (str_contains(PHP_OS, 'FreeBSD')) die('skip different behavior on FreeBSD');
 <?php
 
 var_dump(posix_setrlimit(POSIX_RLIMIT_NOFILE, 128, 128));
-var_dump(posix_setrlimit(POSIX_RLIMIT_NOFILE, 129, 128));
+try {
+	posix_setrlimit(POSIX_RLIMIT_NOFILE, 129, 128);
+} catch (\ValueError $e) {
+	echo $e->getMessage(), PHP_EOL;
+}
 
 ?>
 --EXPECT--
 bool(true)
-bool(false)
+posix_setrlimit(): Argument #2 ($soft_limit) must be lower or equal to 128