Fix [-Wimplicit-fallthrough] warnings in SimpleXML extension

Girgias · Girgias · commit a1a05c78bf9d · 2020-10-01T20:31:52.000+01:00
diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c
@@ -496,7 +496,7 @@ static zval *sxe_prop_dim_write(zend_object *object, zval *member, zval *value,
 					value_str = Z_STR(zval_copy);
 					break;
 				}
-				/* break is missing intentionally */
+				fallthrough;
 			default:
 				if (member == &tmp_zv) {
 					zval_ptr_dtor_str(&tmp_zv);

Original file line number	Diff line number	Diff line change
`@@ -496,7 +496,7 @@ static zval sxe_prop_dim_write(zend_object object, zval member, zval value,`
`496`	`496`	`value_str = Z_STR(zval_copy);`
`497`	`497`	`break;`
`498`	`498`	`}`
`499`		`- /* break is missing intentionally */`
	`499`	`+ fallthrough;`
`500`	`500`	`default:`
`501`	`501`	`if (member == &tmp_zv) {`
`502`	`502`	`zval_ptr_dtor_str(&tmp_zv);`