Skip to content

Commit a57fe1b

Browse files
committed
Merge branch 'PHP-8.5'
* PHP-8.5: Treat accept failing with SOCK_EAGAIN as success in CLI web server
2 parents c07b9cc + 9130ddb commit a57fe1b

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

sapi/cli/php_cli_server.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2712,14 +2712,16 @@ static zend_result php_cli_server_do_event_for_each_fd_callback(void *_params, p
27122712
struct sockaddr *sa = pemalloc(server->socklen, 1);
27132713
client_sock = accept(server->server_sock, sa, &socklen);
27142714
if (!ZEND_VALID_SOCKET(client_sock)) {
2715-
int err = php_socket_errno();
2716-
if (err != SOCK_EAGAIN && php_cli_server_log_level >= PHP_CLI_SERVER_LOG_ERROR) {
2715+
pefree(sa, 1);
2716+
if (php_socket_errno() == SOCK_EAGAIN) {
2717+
return SUCCESS;
2718+
}
2719+
if (php_cli_server_log_level >= PHP_CLI_SERVER_LOG_ERROR) {
27172720
char *errstr = php_socket_strerror(php_socket_errno(), NULL, 0);
27182721
php_cli_server_logf(PHP_CLI_SERVER_LOG_ERROR,
27192722
"Failed to accept a client (reason: %s)", errstr);
27202723
efree(errstr);
27212724
}
2722-
pefree(sa, 1);
27232725
return FAILURE;
27242726
}
27252727
if (SUCCESS != php_set_sock_blocking(client_sock, 0)) {

0 commit comments

Comments
 (0)