Improve performance of text node allocation by marking the text node construction as always inline

nielsdos · nielsdos · commit a86e6687640c · 2024-04-28T10:32:41.000+02:00
diff --git a/ext/dom/html5_parser.c b/ext/dom/html5_parser.c
@@ -73,7 +73,7 @@ static const php_dom_ns_magic_token *get_libxml_namespace_href(uintptr_t lexbor_
     }
 }
 
-static xmlNodePtr lexbor_libxml2_bridge_new_text_node_fast(xmlDocPtr lxml_doc, const lxb_char_t *data, size_t data_length, bool compact_text_nodes)
+static zend_always_inline xmlNodePtr lexbor_libxml2_bridge_new_text_node_fast(xmlDocPtr lxml_doc, const lxb_char_t *data, size_t data_length, bool compact_text_nodes)
 {
     if (compact_text_nodes && data_length < LXML_INTERNED_STRINGS_SIZE) {
         /* See xmlSAX2TextNode() in libxml2 */

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ static const php_dom_ns_magic_token *get_libxml_namespace_href(uintptr_t lexbor_`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`-static xmlNodePtr lexbor_libxml2_bridge_new_text_node_fast(xmlDocPtr lxml_doc, const lxb_char_t *data, size_t data_length, bool compact_text_nodes)`
	`76`	`+static zend_always_inline xmlNodePtr lexbor_libxml2_bridge_new_text_node_fast(xmlDocPtr lxml_doc, const lxb_char_t *data, size_t data_length, bool compact_text_nodes)`
`77`	`77`	`{`
`78`	`78`	`if (compact_text_nodes && data_length < LXML_INTERNED_STRINGS_SIZE) {`
`79`	`79`	`/* See xmlSAX2TextNode() in libxml2 */`