changes from review

Author: devnexen

UPGRADING

@@ -424,6 +424,9 @@ PHP 8.5 UPGRADE NOTES
 - PCRE:
   . Upgraded to pcre2lib from 10.44 to 10.45.
 
+- PDO_Sqlite:
+  . Increased minimum release version support from 3.7.7 to 3.7.17.
+
 - Readline:
   . The return types of readline_add_history(), readline_clear_history(), and
     readline_callback_handler_install() have been changed to true, rather

ext/pdo_sqlite/pdo_sqlite.c

@@ -417,7 +417,6 @@ PHP_MINIT_FUNCTION(pdo_sqlite)
 	REGISTER_PDO_CLASS_CONST_LONG("SQLITE_OPEN_CREATE", (zend_long)SQLITE_OPEN_CREATE);
 	REGISTER_PDO_CLASS_CONST_LONG("SQLITE_ATTR_READONLY_STATEMENT", (zend_long)PDO_SQLITE_ATTR_READONLY_STATEMENT);
 	REGISTER_PDO_CLASS_CONST_LONG("SQLITE_ATTR_EXTENDED_RESULT_CODES", (zend_long)PDO_SQLITE_ATTR_EXTENDED_RESULT_CODES);
-	REGISTER_PDO_CLASS_CONST_LONG("SQLITE_ATTR_BUSY_STATEMENT", (zend_long)PDO_SQLITE_ATTR_BUSY_STATEMENT);
 
 	pdosqlite_ce = register_class_Pdo_Sqlite(pdo_dbh_ce);
 	pdosqlite_ce->create_object = pdo_dbh_new;

ext/pdo_sqlite/tests/pdo_sqlite_statement_getattribute.phpt

@@ -14,20 +14,7 @@ var_dump($st->getAttribute(PDO::SQLITE_ATTR_READONLY_STATEMENT));
 $st = $db->prepare('CREATE TABLE test_sqlite_stmt_getattribute (a TEXT);');
 
 var_dump($st->getAttribute(PDO::SQLITE_ATTR_READONLY_STATEMENT));
-
-$st->execute();
-
-$db->prepare("INSERT INTO test_sqlite_stmt_getattribute VALUES ('interleaved'), ('statements')")->execute();
-$st = $db->prepare("SELECT * FROM test_sqlite_stmt_getattribute");
-
-var_dump($st->getAttribute(PDO::SQLITE_ATTR_BUSY_STATEMENT));
-
-$st->execute();
-
-var_dump($st->getAttribute(PDO::SQLITE_ATTR_BUSY_STATEMENT));
 ?>
 --EXPECT--
 bool(true)
 bool(false)
-bool(false)
-bool(true)

ext/pdo_sqlite/tests/subclasses/pdo_sqlite_constants.phpt

@@ -13,6 +13,7 @@ var_dump(Pdo\Sqlite::OPEN_READWRITE);
 var_dump(Pdo\Sqlite::OPEN_CREATE);
 var_dump(Pdo\Sqlite::ATTR_READONLY_STATEMENT);
 var_dump(Pdo\Sqlite::ATTR_EXTENDED_RESULT_CODES);
+var_dump(Pdo\Sqlite::ATTR_BUSY_STATEMENT);
 
 ?>
 --EXPECTF--
@@ -24,3 +25,4 @@ int(%d)
 int(%d)
 int(%d)
 int(%d)
+int(%d)

ext/pdo_sqlite/tests/subclasses/pdo_sqlite_getattr_busy.phpt

@@ -0,0 +1,19 @@
+--TEST--
+Pdo\Sqlite::ATTR_BUSY_STATEMENT usage
+--EXTENSIONS--
+pdo_sqlite
+--FILE--
+<?php
+
+$db = new Pdo\Sqlite('sqlite::memory:');
+
+$db->query('CREATE TABLE test_busy (a string);');
+$db->query('INSERT INTO test_busy VALUES ("interleaved"), ("statements")');
+$st = $db->prepare('SELECT a FROM test_busy');
+var_dump($st->getAttribute(Pdo\Sqlite::ATTR_BUSY_STATEMENT));
+$st->execute();
+var_dump($st->getAttribute(Pdo\Sqlite::ATTR_BUSY_STATEMENT));
+?>
+--EXPECTF--
+bool(false)
+bool(true)