Skip to content

Commit ac2e681

Browse files
jorgsowajorgsowa
committed
added deprecation message to deprecated DATE_RFC7231 constants
1 parent 550763f commit ac2e681

File tree

7 files changed

+25
-15
lines changed

7 files changed

+25
-15
lines changed

‎ext/date/php_date.stub.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
* @var string
5555
* @cvalue DATE_FORMAT_RFC7231
5656
*/
57-
#[Deprecated]
57+
#[\Deprecated(since: '8.5', message: "as this format ignores the associated timezone and always uses GMT")]
5858
const DATE_RFC7231 = "D, d M Y H:i:s \\G\\M\\T";
5959

6060
/**
@@ -304,7 +304,7 @@ interface DateTimeInterface
304304

305305
public const string RFC1123 = DATE_RFC1123;
306306

307-
#[Deprecated]
307+
#[\Deprecated(since: '8.5', message: "as this format ignores the associated timezone and always uses GMT")]
308308
public const string RFC7231 = DATE_RFC7231;
309309

310310
public const string RFC2822 = DATE_RFC2822;

‎ext/date/php_date_arginfo.h‎

Lines changed: 13 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎ext/date/tests/DateTimeImmutable_constants.phpt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ var_dump(
2222

2323
?>
2424
--EXPECTF--
25-
Deprecated: Constant DATE_RFC7231 is deprecated in %s on line %d
25+
Deprecated: Constant DATE_RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTimeImmutable_constants.php on line 12
2626

27-
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated in %s on line %d
27+
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTimeImmutable_constants.php on line 12
2828
bool(true)
2929
bool(true)
3030
bool(true)

‎ext/date/tests/DateTimeInterface_constants.phpt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ var_dump(
2222

2323
?>
2424
--EXPECTF--
25-
Deprecated: Constant DATE_RFC7231 is deprecated in %s on line %d
25+
Deprecated: Constant DATE_RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTimeInterface_constants.php on line 12
2626

27-
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated in %s on line %d
27+
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTimeInterface_constants.php on line 12
2828
bool(true)
2929
bool(true)
3030
bool(true)

‎ext/date/tests/DateTime_constants.phpt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ var_dump(
2222

2323
?>
2424
--EXPECTF--
25-
Deprecated: Constant DATE_RFC7231 is deprecated in %s on line %d
25+
Deprecated: Constant DATE_RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTime_constants.php on line 12
2626

27-
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated in %s on line %d
27+
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTime_constants.php on line 12
2828
bool(true)
2929
bool(true)
3030
bool(true)

‎ext/date/tests/DateTime_format_basic2.phpt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ string(32) "Thursday, 14-Jul-05 22:30:41 BST"
3535
string(29) "Thu, 14 Jul 05 22:30:41 +0100"
3636
string(31) "Thu, 14 Jul 2005 22:30:41 +0100"
3737

38-
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated in %s on line %d
38+
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /Users/bonifacy/CLionProjects/php-src/ext/date/tests/DateTime_format_basic2.php on line 16
3939
string(29) "Thu, 14 Jul 2005 22:30:41 GMT"
4040
string(31) "Thu, 14 Jul 2005 22:30:41 +0100"
4141
string(25) "2005-07-14T22:30:41+01:00"

‎ext/date/tests/date_constants.phpt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Date constants
4545
);
4646
?>
4747
--EXPECTF--
48-
Deprecated: Constant DATE_RFC7231 is deprecated in %s on line %d
48+
Deprecated: Constant DATE_RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in %s on line %d
4949
string(25) "2006-07-01T14:27:30+02:00"
5050
string(25) "2006-05-30T14:32:13+02:00"
5151
string(35) "Saturday, 01-Jul-2006 14:27:30 CEST"
@@ -76,9 +76,9 @@ string(25) "2006-07-01T14:27:30+02:00"
7676
string(25) "2006-05-30T14:32:13+02:00"
7777

7878

79-
Deprecated: Constant DATE_RFC7231 is deprecated in %s on line %d
79+
Deprecated: Constant DATE_RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in %s on line %d
8080

81-
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated in %s on line %d
81+
Deprecated: Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in %s on line %d
8282
bool(true)
8383
bool(true)
8484
bool(true)

0 commit comments

Comments
 (0)