Update return types of transliterator_get_error_code(), transliterator_get_error_message(), TransLiterator::getErrorCode(), and TransLiterator::getErrorMessage() (#18470)

Returning false is impossible.

Author: ndossche

UPGRADING

@@ -221,12 +221,15 @@ PHP 8.5 UPGRADE NOTES
 - Intl:
   . IntlDateFormatter::setTimeZone()/datefmt_set_timezone()
     throws an IntlException on uninitialised classes/clone failures.
-
   . grapheme_extract() properly assigns $next value when skipping over
     invalid starting bytes. Previously there were cases where it would
     point to the start of the grapheme boundary instead of the end.
   . Locale:: methods throw a ValueError when locale inputs contain null
     bytes.
+  . transliterator_get_error_code(), transliterator_get_error_message()
+    TransLiterator::getErrorCode(), and TransLiterator::getErrorMessage()
+    have dropped the false from the return type union. Returning false
+    was actually never possible.
 
 - libxml:
   . libxml_set_external_entity_loader() now has a formal return type of true.

ext/intl/php_intl.stub.php

@@ -637,6 +637,6 @@ function transliterator_create_inverse(Transliterator $transliterator): ?Transli
 
 function transliterator_transliterate(Transliterator|string $transliterator, string $string, int $start = 0, int $end = -1): string|false {}
 
-function transliterator_get_error_code(Transliterator $transliterator): int|false {}
+function transliterator_get_error_code(Transliterator $transliterator): int {}
 
-function transliterator_get_error_message(Transliterator $transliterator): string|false {}
+function transliterator_get_error_message(Transliterator $transliterator): string {}

ext/intl/php_intl_arginfo.h

@@ -49,11 +49,11 @@ public function transliterate(string $string, int $start = 0, int $end = -1): st
      * @tentative-return-type
      * @alias transliterator_get_error_code
      */
-    public function getErrorCode(): int|false {}
+    public function getErrorCode(): int {}
 
     /**
      * @tentative-return-type
      * @alias transliterator_get_error_message
      */
-    public function getErrorMessage(): string|false {}
+    public function getErrorMessage(): string {}
 }

ext/intl/transliterator/transliterator.stub.php

@@ -437,8 +437,6 @@ PHP_FUNCTION( transliterator_get_error_code )
 
 	/* Fetch the object (without resetting its last error code ). */
 	to = Z_INTL_TRANSLITERATOR_P( object );
-	if (to == NULL )
-		RETURN_FALSE;
 
 	RETURN_LONG( (zend_long) TRANSLITERATOR_ERROR_CODE( to ) );
 }
@@ -460,8 +458,6 @@ PHP_FUNCTION( transliterator_get_error_message )
 
 	/* Fetch the object (without resetting its last error code ). */
 	to = Z_INTL_TRANSLITERATOR_P( object );
-	if (to == NULL )
-		RETURN_FALSE;
 
 	/* Return last error message. */
 	message = intl_error_get_message( TRANSLITERATOR_ERROR_P( to ) );