Fix bug where large bigints may be truncated

Unless stringified results are requested, we need to parse large
bigints as unsigned, to avoid wrap-around behavior.

Co-authored-by: Christoph M. Becker <[email protected]>

Closes GH-7837.

Author: NathanFreeman

NEWS

@@ -16,6 +16,9 @@ PHP                                                                        NEWS
   . Fixed bug GH-7826 (Inconsistent argument name in hash_hmac_file and
     hash_file). (cmb)
 
+- MySQLnd:
+  . Fixed bug where large bigints may be truncated. (Nathan Freeman, cmb)
+
 - OCI8:
   . Fixed bug GH-7765 (php_oci_cleanup_global_handles segfaults at second
     call). (cmb)

ext/mysqli/tests/gh7837.phpt

@@ -0,0 +1,42 @@
+--TEST--
+Bug GH-7837 (large bigints may be truncated)
+--SKIPIF--
+<?php
+require_once("skipif.inc");
+if (strpos(mysqli_get_client_info(), "mysqlnd") === false) {
+    die("skip requires mysqlnd");
+}
+require_once("skipifconnectfailure.inc");
+?>
+--FILE--
+<?php
+require_once("connect.inc");
+
+$mysql = new mysqli($host, $user, $passwd, $db, $port, $socket);
+$mysql->options(MYSQLI_OPT_INT_AND_FLOAT_NATIVE, true);
+$mysql->query("DROP TABLE IF EXISTS test");
+$mysql->query("CREATE TABLE test (`ubigint` bigint unsigned NOT NULL) ENGINE=InnoDB");
+$mysql->query("INSERT INTO test (`ubigint`) VALUES (18446744073709551615)");
+$mysql->query("INSERT INTO test (`ubigint`) VALUES (9223372036854775808)");
+$mysql->query("INSERT INTO test (`ubigint`) VALUES (1)");
+$result = $mysql->query("SELECT ubigint FROM test");
+var_dump($result->fetch_all());
+?>
+--EXPECT--
+array(3) {
+  [0]=>
+  array(1) {
+    [0]=>
+    string(20) "18446744073709551615"
+  }
+  [1]=>
+  array(1) {
+    [0]=>
+    string(19) "9223372036854775808"
+  }
+  [2]=>
+  array(1) {
+    [0]=>
+    int(1)
+  }
+}

ext/mysqlnd/mysqlnd_wireprotocol.c

@@ -1634,9 +1634,9 @@ php_mysqlnd_rowp_read_text_protocol_aux(MYSQLND_ROW_BUFFER * row_buffer, zval *
 				} else {
 					uint64_t v =
 #ifndef PHP_WIN32
-						(uint64_t) atoll((char *) p);
+						strtoull((char *) p, NULL, 10);
 #else
-						(uint64_t) _atoi64((char *) p);
+						_strtoui64((char *) p, NULL, 10);
 #endif
 					zend_bool uns = fields_metadata[i].flags & UNSIGNED_FLAG? TRUE:FALSE;
 					/* We have to make it ASCIIZ temporarily */