Declare tentative return types in ext/spl - part 3 (#7239)

Author: kocsismate

ext/spl/spl_iterators.stub.php

@@ -35,7 +35,7 @@ class StudentIdFilter extends FilterIterator
         $this->id = $other->getId();
     }
 
-    public function accept()
+    public function accept(): bool
     {
         echo "ACCEPT ".$this->current()->getId()." == ".$this->id."\n";
         return $this->current()->getId() == $this->id;

ext/spl/spl_iterators_arginfo.h

@@ -10,7 +10,7 @@ class MyRecursiveArrayIterator extends ArrayIterator implements RecursiveIterato
         return is_array($this->current());
     }
 
-    function getChildren()
+    function getChildren(): MyRecursiveArrayIterator
     {
         return new MyRecursiveArrayIterator($this->current());
     }

ext/spl/tests/array_005.phpt

@@ -13,25 +13,25 @@ class Collection implements Iterator
         $this->array = $a;
     }
 
-    public function current()
+    public function current(): mixed
     {
         echo __METHOD__ . "\n";
         return current($this->array);
     }
 
-    public function key()
+    public function key(): mixed
     {
         echo __METHOD__ . "\n";
         return key($this->array);
     }
 
-    public function next()
+    public function next(): void
     {
         echo __METHOD__ . "\n";
         $this->valid = (false !== next($this->array));
     }
 
-    public function valid()
+    public function valid(): bool
     {
         echo __METHOD__ . "\n";
         return $this->valid;
@@ -46,7 +46,7 @@ class Collection implements Iterator
 
 class TestFilter extends FilterIterator
 {
-    public function accept()
+    public function accept(): bool
     {
         echo __METHOD__ . "\n";
         throw new Exception("Failure in Accept");

ext/spl/tests/array_009a.phpt

@@ -6,18 +6,18 @@ class BlaIterator implements Iterator
 {
     public function rewind(): void { }
 
-    public function next() { }
+    public function next(): void { }
 
-    public function valid() {
+    public function valid(): bool {
         return true;
     }
 
-    public function current()
+    public function current(): mixed
     {
       throw new Exception('boo');
     }
 
-    public function key() { }
+    public function key(): mixed { return null; }
 }
 
 $it = new BlaIterator();

ext/spl/tests/bug37457.phpt

@@ -24,7 +24,7 @@ test( function() {
 echo "FilterIterator... ";
 class FilterIteratorTest extends FilterIterator {
     function __construct(){}
-    function accept(){}
+    function accept(): bool {}
 }
 test( function() {
     $o = new FilterIteratorTest;
@@ -34,7 +34,7 @@ test( function() {
 echo "RecursiveFilterIterator... ";
 class RecursiveFilterIteratorTest extends RecursiveFilterIterator {
     function __construct(){}
-    function accept(){}
+    function accept(): bool {}
 }
 test( function() {
 $o = new RecursiveFilterIteratorTest;

ext/spl/tests/bug42703.phpt

@@ -9,7 +9,7 @@ class RecursiveArrayIteratorIterator extends RecursiveIteratorIterator {
   function rewind(): void {
     echo "dummy\n";
   }
-  function endChildren() {
+  function endChildren(): void {
       global $count;
       echo $this->getDepth();
       if (--$count > 0) {

ext/spl/tests/bug54384.phpt

@@ -7,39 +7,39 @@ class foo implements \RecursiveIterator
   {
     public $foo = [];
 
-    public Function current ()
+    public Function current(): mixed
       {
         return current ($this->foo);
       }
 
-    public Function key ()
+    public Function key(): mixed
       {
         return key ($this->foo);
       }
 
-    public Function next ()
+    public Function next(): void
       {
         next ($this->foo);
       }
 
-    public Function rewind ()
+    public Function rewind(): void
       {
         reset ($this->foo);
       }
 
-    public Function valid ()
+    public Function valid(): bool
       {
         return current ($this->foo) !== false;
       }
 
-    public Function getChildren ()
+    public Function getChildren(): ?RecursiveIterator
       {
         return current ($this->foo);
       }
 
-    public Function hasChildren ()
+    public Function hasChildren(): bool
       {
-        return (bool) count ($this->foo);
+        return (bool) count($this->foo);
       }
   }
 
@@ -53,7 +53,7 @@ class fooIterator extends \RecursiveFilterIterator
         /* CRASH */
       }
 
-    public Function accept ()
+    public Function accept(): bool
       {
         return true;
       }

ext/spl/tests/bug69970.phpt

@@ -19,22 +19,22 @@ class Container implements Iterator
         $this->container->append($element);
     }
 
-    public function current()
+    public function current(): mixed
     {
         return $this->iterator->current();
     }
 
-    public function next()
+    public function next(): void
     {
         $this->iterator->next();
     }
 
-    public function key()
+    public function key(): mixed
     {
         return $this->iterator->key();
     }
 
-    public function valid()
+    public function valid(): bool
     {
         return $this->iterator->valid();
     }