memory leak fixed with old school

juan-morales · juan-morales · commit b4343011829a · 2025-06-09T23:34:35.000-03:00
diff --git a/ext/json/json.c b/ext/json/json.c
@@ -375,6 +375,11 @@ PHP_FUNCTION(json_last_error_msg)
 {
 	ZEND_PARSE_PARAMETERS_NONE();
 
-	RETURN_STRING(php_json_get_error_msg(JSON_G(error_code)));
+	char *msg = php_json_get_error_msg(JSON_G(error_code));
+    RETVAL_STRING(msg);
+	if (JSON_G(error_code) == PHP_JSON_ERROR_SYNTAX) {
+        efree(msg);
+    }
+	//original:RETURN_STRING(php_json_get_error_msg(JSON_G(error_code)));
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -375,6 +375,11 @@ PHP_FUNCTION(json_last_error_msg)`
`375`	`375`	`{`
`376`	`376`	`ZEND_PARSE_PARAMETERS_NONE();`
`377`	`377`
`378`		`- RETURN_STRING(php_json_get_error_msg(JSON_G(error_code)));`
	`378`	`+ char *msg = php_json_get_error_msg(JSON_G(error_code));`
	`379`	`+ RETVAL_STRING(msg);`
	`380`	`+ if (JSON_G(error_code) == PHP_JSON_ERROR_SYNTAX) {`
	`381`	`+ efree(msg);`
	`382`	`+ }`
	`383`	`+ //original:RETURN_STRING(php_json_get_error_msg(JSON_G(error_code)));`
`379`	`384`	`}`
`380`	`385`	`/* }}} */`