Add deprecation

Not yet wired to emit anything yet though

Author: DanielEScherzer

Zend/zend_attributes.c

@@ -366,6 +366,16 @@ static void validate_class_alias(
 		} else {
 			zend_ast *attributes_ast = Z_ASTVAL_P(nested_attribs);
 			compile_alias_attributes(&( alias_obj->attributes), attributes_ast);
+
+			zend_attribute *deprecated_attribute = zend_get_attribute_str(
+				alias_obj->attributes,
+				"deprecated",
+				strlen("deprecated")
+			);
+
+			if (deprecated_attribute) {
+				alias_obj->alias_flags |= ZEND_ACC_DEPRECATED;
+			}
 		}
 	}
 

Zend/zend_class_alias.c

@@ -25,6 +25,7 @@ zend_class_alias * zend_class_alias_init(zend_class_entry *ce) {
 
 	alias->ce = ce;
 	alias->attributes = NULL;
+	alias->alias_flags = 0;
 
 	return alias;
 }

Zend/zend_class_alias.h

@@ -25,6 +25,7 @@ struct _zend_class_alias {
     zend_refcounted_h gc;
     zend_class_entry *ce;
     HashTable *attributes;
+    uint32_t alias_flags;
 };
 
 typedef struct _zend_class_alias zend_class_alias;

ext/reflection/php_reflection.c

@@ -7922,13 +7922,25 @@ ZEND_METHOD(ReflectionClassAlias, __toString)
 
 	smart_str_append_printf(
 		&str,
-		"%s - alias for %s",
+		"%s - %salias for %s",
 		Z_STRVAL_P(reflection_prop_name(ZEND_THIS)),
+		(alias->alias_flags & ZEND_ACC_DEPRECATED) ? "deprecated " : "",
 		ZSTR_VAL(alias->ce->name)
 	);
 	RETURN_STR(smart_str_extract(&str));
 }
 
+ZEND_METHOD(ReflectionClassAlias, isDeprecated)
+{
+	reflection_object *intern;
+	zend_class_alias *alias;
+
+	ZEND_PARSE_PARAMETERS_NONE();
+
+	GET_REFLECTION_OBJECT_PTR(alias);
+	RETURN_BOOL(alias->alias_flags & ZEND_ACC_DEPRECATED);
+}
+
 PHP_MINIT_FUNCTION(reflection) /* {{{ */
 {
 	memcpy(&reflection_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));

ext/reflection/php_reflection.stub.php

@@ -939,5 +939,7 @@ public function __construct(string $name) {}
 
     public function __toString(): string {}
 
+    public function isDeprecated(): bool {}
+
     public function getAttributes(?string $name = null, int $flags = 0): array {}
 }

ext/reflection/php_reflection_arginfo.h

@@ -0,0 +1,18 @@
+--TEST--
+ReflectionClassAlias::isDeprecated()
+--FILE--
+<?php
+
+#[ClassAlias('OldAlias', [new Deprecated()])]
+#[ClassAlias('NewAlias')]
+class Demo {}
+
+$r = new ReflectionClassAlias( 'OldAlias' );
+var_dump( $r->isDeprecated() );
+
+$r = new ReflectionClassAlias( 'NewAlias' );
+var_dump( $r->isDeprecated() );
+?>
+--EXPECT--
+bool(true)
+bool(false)

ext/reflection/tests/ReflectionClassAlias_isDeprecated.phpt

@@ -0,0 +1,13 @@
+--TEST--
+ReflectionClassAlias::__toString() for a deprecated alias
+--FILE--
+<?php
+
+#[ClassAlias('Other', [new Deprecated()])]
+class Demo {}
+
+$r = new ReflectionClassAlias( 'Other' );
+echo $r;
+?>
+--EXPECT--
+Other - deprecated alias for Demo