Fixing memory leak

JarneClauw · JarneClauw · commit bf64f38a9e98 · 2026-04-13T21:05:39.000+02:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -2169,6 +2169,7 @@ PHP_FUNCTION(openssl_x509_parse)
 	str_serial = i2s_ASN1_INTEGER(NULL, asn1_serial);
 	/* Can return NULL on error or memory allocation failure */
 	if (!str_serial) {
+		OPENSSL_free(hex_serial);
 		php_openssl_store_errors();
 		goto err;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2169,6 +2169,7 @@ PHP_FUNCTION(openssl_x509_parse)`
`2169`	`2169`	`str_serial = i2s_ASN1_INTEGER(NULL, asn1_serial);`
`2170`	`2170`	`/* Can return NULL on error or memory allocation failure */`
`2171`	`2171`	`if (!str_serial) {`
	`2172`	`+ OPENSSL_free(hex_serial);`
`2172`	`2173`	`php_openssl_store_errors();`
`2173`	`2174`	`goto err;`
`2174`	`2175`	`}`