phar: Fix file descriptor/memory leak when opening central fp fails

ndossche · ndossche · commit c89f25bf6902 · 2025-10-13T09:07:37.000+02:00
Closes GH-20145.
diff --git a/NEWS b/NEWS
@@ -23,6 +23,7 @@ PHP                                                                        NEWS
   . Fix memory leak of argument in webPhar. (nielsdos)
   . Fix memory leak when setAlias() fails. (nielsdos)
   . Fix memory leak in phar_parse_zipfile() error handling. (nielsdos)
+  . Fix file descriptor/memory leak when opening central fp fails. (nielsdos)
 
 - Random:
   . Fix Randomizer::__serialize() w.r.t. INDIRECTs. (nielsdos)
diff --git a/ext/phar/zip.c b/ext/phar/zip.c
@@ -1417,6 +1417,7 @@ int phar_zip_flush(phar_archive_data *phar, char *user_stub, zend_long len, int
 	pass.centralfp = php_stream_fopen_tmpfile();
 
 	if (!pass.centralfp) {
+		php_stream_close(pass.filefp);
 		goto fperror;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1417,6 +1417,7 @@ int phar_zip_flush(phar_archive_data phar, char user_stub, zend_long len, int`
`1417`	`1417`	`pass.centralfp = php_stream_fopen_tmpfile();`
`1418`	`1418`
`1419`	`1419`	`if (!pass.centralfp) {`
	`1420`	`+ php_stream_close(pass.filefp);`
`1420`	`1421`	`goto fperror;`
`1421`	`1422`	`}`
`1422`	`1423`