Skip to content

Commit cd31ec7

Browse files
committed
Address review comments
Merge code blocks, remove relative paths for headers
1 parent 2bd54ec commit cd31ec7

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

ext/opcache/jit/zend_jit_helpers.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
+----------------------------------------------------------------------+
1717
*/
1818

19-
#include "../../../Zend/zend_types.h"
19+
#include "Zend/zend_types.h"
2020
#include "Zend/zend_API.h"
2121

2222
static ZEND_COLD void undef_result_after_exception(void) {

ext/opcache/jit/zend_jit_ir.c

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* +----------------------------------------------------------------------+
1717
*/
1818

19-
#include "../../../Zend/zend_type_info.h"
19+
#include "Zend/zend_type_info.h"
2020
#include "jit/ir/ir.h"
2121
#include "jit/ir/ir_builder.h"
2222
#include "jit/tls/zend_jit_tls.h"
@@ -12787,7 +12787,7 @@ static int zend_jit_fetch_dim_read(zend_jit_ctx *jit,
1278712787
}
1278812788
}
1278912789

12790-
if (opline->opcode == ZEND_FETCH_LIST_R) {
12790+
if (opline->opcode != ZEND_FETCH_DIM_IS) {
1279112791
ir_ref ref;
1279212792

1279312793
may_throw = 1;
@@ -12797,19 +12797,11 @@ static int zend_jit_fetch_dim_read(zend_jit_ctx *jit,
1279712797
jit_SET_EX_OPLINE(jit, opline);
1279812798
ref = jit_ZVAL_ADDR(jit, op1_addr);
1279912799
}
12800-
ir_CALL_1(IR_VOID, ir_CONST_FC_FUNC(zend_jit_invalid_array_use), ref);
12801-
}
12802-
if (opline->opcode != ZEND_FETCH_DIM_IS && opline->opcode != ZEND_FETCH_LIST_R) {
12803-
ir_ref ref;
12804-
12805-
may_throw = 1;
12806-
if ((op1_info & MAY_BE_UNDEF) || (op2_info & MAY_BE_UNDEF)) {
12807-
ref = jit_ZVAL_ADDR(jit, orig_op1_addr);
12800+
if (opline->opcode == ZEND_FETCH_LIST_R) {
12801+
ir_CALL_1(IR_VOID, ir_CONST_FC_FUNC(zend_jit_invalid_array_use), ref);
1280812802
} else {
12809-
jit_SET_EX_OPLINE(jit, opline);
12810-
ref = jit_ZVAL_ADDR(jit, op1_addr);
12803+
ir_CALL_1(IR_VOID, ir_CONST_FC_FUNC(zend_jit_invalid_array_access), ref);
1281112804
}
12812-
ir_CALL_1(IR_VOID, ir_CONST_FC_FUNC(zend_jit_invalid_array_access), ref);
1281312805
}
1281412806

1281512807
jit_set_Z_TYPE_INFO(jit, res_addr, IS_NULL);

0 commit comments

Comments
 (0)