ext/spl: Deprecate ArrayObject and ArrayIterator with objects

RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_arrayiterator_with_objects

Author: Girgias

ext/spl/spl_array.c

@@ -984,6 +984,12 @@ static void spl_array_set_array(zval *object, spl_array_object *intern, zval *ar
 			}
 		}
 	} else {
+		php_error_docref(NULL, E_DEPRECATED,
+			"Using an object as a backing array for %s is deprecated, as it allows violating class constraints and invariants",
+			instanceof_function(Z_OBJCE_P(object), spl_ce_ArrayIterator) ? "ArrayIterator" : "ArrayObject");
+		if (UNEXPECTED(EG(exception))) {
+			return;
+		}
 		if (Z_OBJ_HT_P(array) == &spl_handler_ArrayObject) {
 			ZVAL_COPY_VALUE(&garbage, &intern->array);
 			if (just_array)	{

…ect__serialize_saves_iterator_class.phpt …ect__serialize_saves_iterator_class.phptext/spl/tests/ArrayObject__serialize_saves_iterator_class.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject__serialize_saves_iterator_class.phpt ext/spl/tests/ArrayObject__serialize_saves_iterator_class.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject__serialize_saves_iterator_class.phpt

@@ -9,7 +9,8 @@ $c = clone $b;
 var_dump($c);
 
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
 object(ArrayObject)#3 (1) {
   ["storage":"ArrayObject":private]=>
   array(3) {

…s/ArrayObject_clone_other_std_props.phpt …t/ArrayObject_clone_other_std_props.phptext/spl/tests/ArrayObject_clone_other_std_props.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_clone_other_std_props.phpt ext/spl/tests/ArrayObject_clone_other_std_props.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_clone_other_std_props.phpt

@@ -11,5 +11,7 @@ new ArrayObject(Foo::Bar);
 
 ?>
 --EXPECTF--
+Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
+
 Fatal error: Uncaught InvalidArgumentException: Enums are not compatible with ArrayObject in %s:%d
 %a

…/tests/ArrayObject_dump_during_sort.phpt …Object/ArrayObject_dump_during_sort.phptext/spl/tests/ArrayObject_dump_during_sort.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_dump_during_sort.phpt ext/spl/tests/ArrayObject_dump_during_sort.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_dump_during_sort.phpt

@@ -21,7 +21,8 @@ var_dump(get_object_vars($ao));
 var_dump($ao->getObjectVars());
 
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
 array(0) {
 }
 array(1) {

ext/spl/tests/ArrayObject_enum.phpt …/tests/ArrayObject/ArrayObject_enum.phptext/spl/tests/ArrayObject_enum.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_enum.phpt ext/spl/tests/ArrayObject_enum.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_enum.phpt

@@ -10,7 +10,8 @@ $ao['a'] = 42;
 var_dump($arr);
 
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
 array(2) {
   ["a"]=>
   int(1)

…bject_exchange_array_during_sorting.phpt …bject_exchange_array_during_sorting.phptext/spl/tests/ArrayObject_exchange_array_during_sorting.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_exchange_array_during_sorting.phpt ext/spl/tests/ArrayObject_exchange_array_during_sorting.phpt renamed to ext/spl/tests/ArrayObject/ArrayObject_exchange_array_during_sorting.phpt

@@ -12,5 +12,6 @@ try {
   echo $e->getMessage(), "\n";
 }
 ?>
---EXPECT--
+--EXPECTF--
+Deprecated: ArrayObject::exchangeArray(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
 Overloaded object of type SplFixedArray is not compatible with ArrayObject