Skip to content

Commit d45f4ce

Browse files
authored
Drop Laravel from benchmark CI (#12595)
Two issues: - The demo page does not seem to be doing much, so the value is limited. - The benchmark instruction count has too much variance to be useful.
1 parent 110cdd3 commit d45f4ce

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

benchmark/benchmark.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ function main() {
2727
$data['Symfony Demo 2.2.3 JIT'] = runSymfonyDemo(true);
2828
$data['Wordpress 6.2'] = runWordpress(false);
2929
$data['Wordpress 6.2 JIT'] = runWordpress(true);
30-
$data['Laravel 10.10'] = runLaravelDemo(false);
31-
$data['Laravel 10.10 JIT'] = runLaravelDemo(true);
3230
$result = json_encode($data, JSON_PRETTY_PRINT) . "\n";
3331

3432
fwrite(STDOUT, $result);
@@ -91,17 +89,6 @@ function runWordpress(bool $jit): array {
9189
return runValgrindPhpCgiCommand('wordpress', [$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
9290
}
9391

94-
function runLaravelDemo(bool $jit): array {
95-
96-
$dir = __DIR__ . '/repos/laravel-demo-10.10';
97-
cloneRepo($dir, 'https://github.com/php/benchmarking-laravel-demo-10.10.git');
98-
runPhpCommand([$dir . '/artisan', 'config:cache']);
99-
runPhpCommand([$dir . '/artisan', 'event:cache']);
100-
runPhpCommand([$dir . '/artisan', 'route:cache']);
101-
runPhpCommand([$dir . '/artisan', 'view:cache']);
102-
return runValgrindPhpCgiCommand('laravel-demo', [$dir . '/public/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 100);
103-
}
104-
10592
function runPhpCommand(array $args, ?string $cwd = null): ProcessResult {
10693
return runCommand([PHP_BINARY, ...$args], $cwd);
10794
}

0 commit comments

Comments
 (0)