Skip to content

Commit d94a190

Browse files
committed
Use zend_parse_parameters_none() in XmlWriter::openMemory()
And fix incorrect uses in tests
1 parent 6e17fbe commit d94a190

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

ext/xmlwriter/php_xmlwriter.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,6 +1700,10 @@ static PHP_FUNCTION(xmlwriter_open_memory)
17001700
zval *self = getThis();
17011701
ze_xmlwriter_object *ze_obj = NULL;
17021702

1703+
if (zend_parse_parameters_none() == FAILURE) {
1704+
return;
1705+
}
1706+
17031707
if (self) {
17041708
/* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here */
17051709
ze_obj = Z_XMLWRITER_P(self);

ext/xmlwriter/tests/002.phpt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ XMLWriter: libxml2 XML Writer, membuffer, flush
55
--FILE--
66
<?php
77

8-
$doc_dest = '002.xml';
9-
$xw = xmlwriter_open_memory($doc_dest);
8+
$xw = xmlwriter_open_memory();
109
xmlwriter_start_document($xw, '1.0', 'UTF-8');
1110
xmlwriter_start_element($xw, "tag1");
1211
xmlwriter_end_document($xw);

ext/xmlwriter/tests/003.phpt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ XMLWriter: libxml2 XML Writer, membuffer, flush, attribute
55
--FILE--
66
<?php
77

8-
$doc_dest = '003.xml';
9-
$xw = xmlwriter_open_memory($doc_dest);
8+
$xw = xmlwriter_open_memory();
109
xmlwriter_start_document($xw, '1.0', 'UTF-8');
1110
xmlwriter_start_element($xw, "tag1");
1211

0 commit comments

Comments
 (0)