Commit dab2a64
committed
Fix GH-17107: Building ext/intl fails with GCC 8.5.0
A previous fix to be able to build C++ extensions with MSVC[1], was
based on two assumptions:
* `max_align_t` would be defined in stddef.h on Windows
* additionally including cstddef as extern C++ would not interfere with
the already included stddef.h
The former was plain wrong; there is no such typedef (or macro); the
latter was presumptuous, as can be seen in the bug tracker ticket.
Thus we revert that fix, and instead make an exception for Windows,
where we always use the fallback definition, which should work fine on
Windows.
[1] <ab449a7>1 parent 52ebdfb commit dab2a64
1 file changed
+2
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
791 | 791 | | |
792 | 792 | | |
793 | 793 | | |
794 | | - | |
| 794 | + | |
| 795 | + | |
795 | 796 | | |
796 | | - | |
797 | | - | |
798 | | - | |
799 | | - | |
800 | | - | |
801 | 797 | | |
802 | 798 | | |
803 | 799 | | |
| |||
0 commit comments