Fix [-Wimplicit-fallthrough] warnings in FFI extension

Girgias · Girgias · commit dc5f1178e5e3 · 2021-02-04T12:07:35.000Z
diff --git a/ext/ffi/ffi.c b/ext/ffi/ffi.c
@@ -2598,7 +2598,7 @@ static int zend_ffi_pass_var_arg(zval *arg, ffi_type **pass_type, void **arg_val
 
 				return zend_ffi_pass_arg(arg, type, pass_type, arg_values, n, execute_data);
 			}
-			/* break missing intentionally */
+			fallthrough;
 		default:
 			zend_throw_error(zend_ffi_exception_ce, "Unsupported argument type");
 			return FAILURE;

Original file line number	Diff line number	Diff line change
`@@ -2598,7 +2598,7 @@ static int zend_ffi_pass_var_arg(zval arg, ffi_type pass_type, void *arg_val`
`2598`	`2598`
`2599`	`2599`	`return zend_ffi_pass_arg(arg, type, pass_type, arg_values, n, execute_data);`
`2600`	`2600`	`}`
`2601`		`- /* break missing intentionally */`
	`2601`	`+ fallthrough;`
`2602`	`2602`	`default:`
`2603`	`2603`	`zend_throw_error(zend_ffi_exception_ce, "Unsupported argument type");`
`2604`	`2604`	`return FAILURE;`