Skip to content

Commit ddedd15

Browse files
committed
Remove always-true condition in php_conv_open()
1 parent 5e02bca commit ddedd15

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

ext/standard/filters.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,9 +1188,7 @@ static php_conv *php_conv_open(int conv_mode, const HashTable *options, int pers
11881188
retval = pemalloc(sizeof(php_conv_base64_encode), persistent);
11891189
if (lbchars != NULL) {
11901190
if (php_conv_base64_encode_ctor((php_conv_base64_encode *)retval, line_len, lbchars, lbchars_len, 1, persistent) != PHP_CONV_ERR_SUCCESS) {
1191-
if (lbchars != NULL) {
1192-
pefree(lbchars, 0);
1193-
}
1191+
pefree(lbchars, 0);
11941192
goto out_failure;
11951193
}
11961194
pefree(lbchars, 0);

0 commit comments

Comments
 (0)