review

Author: Girgias

ext/soap/soap.c

@@ -1309,7 +1309,8 @@ PHP_METHOD(SoapServer, handle)
 */
 
 			sapi_add_header("Content-Type: text/xml; charset=utf-8", sizeof("Content-Type: text/xml; charset=utf-8")-1, 1);
-			php_stream *stream = php_stream_open_wrapper_ex(service->sdl->source, "rb", REPORT_ERRORS, NULL, /* context */ NULL);
+			php_stream_context *context = php_stream_context_from_zval(NULL, false);
+			php_stream *stream = php_stream_open_wrapper_ex(service->sdl->source, "rb", REPORT_ERRORS, NULL, context);
 			if (stream) {
 				php_stream_passthru(stream);
 				php_stream_close(stream);

ext/soap/tests/SoapServer/handle_non_existing_WSDL_from_get_query.phpt

@@ -6,7 +6,7 @@ soap
 WSDL
 --FILE--
 <?php
-$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl.wsdl';
+$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl_from_get_query.wsdl';
 
 $wsdl = <<<'WSDL'
 <?xml version="1.0" ?>
@@ -72,7 +72,7 @@ $server->handle();
 ?>
 --CLEAN--
 <?php
-$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl.wsdl';
+$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl_from_get_query.wsdl';
 @unlink($wsdlFile);
 ?>
 --EXPECT--

ext/soap/tests/SoapServer/handle_non_existing_WSDL_from_get_query_disable_readfile.phpt

@@ -8,7 +8,7 @@ WSDL
 disable_functions=readfile
 --FILE--
 <?php
-$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl.wsdl';
+$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl_from_get_query_disable_readfile.wsdl';
 
 $wsdl = <<<'WSDL'
 <?xml version="1.0" ?>
@@ -68,16 +68,12 @@ $options = [];
 $server = new SoapServer($wsdlFile, $options);
 
 unlink($wsdlFile);
+$server->handle();
 
-try {
-    $server->handle();
-} catch (Throwable $e) {
-    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
-}
 ?>
 --CLEAN--
 <?php
-$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl.wsdl';
+$wsdlFile = __DIR__ . '/test_handle_non_existent_wsdl_from_get_query_disable_readfile.wsdl';
 @unlink($wsdlFile);
 ?>
 --EXPECT--