Resolve MSVC C4146 Warning

KaseyJenkins · KaseyJenkins · commit e280805fdc1e · 2025-08-01T09:21:18.000+02:00
diff --git a/ext/random/php_random_uint128.h b/ext/random/php_random_uint128.h
@@ -81,7 +81,7 @@ static inline uint64_t php_random_pcgoneseq128xslrr64_rotr64(php_random_uint128_
 		v = (num.hi ^ num.lo),
 		s = num.hi >> 58U;
 
-	return (v >> s) | (v << ((-s) & 63));
+	return (v >> s) | (v << ((~s + 1) & 63));
 }
 # else
 typedef __uint128_t php_random_uint128_t;
@@ -121,7 +121,7 @@ static inline uint64_t php_random_pcgoneseq128xslrr64_rotr64(php_random_uint128_
 		v = ((uint64_t) (num >> 64U)) ^ (uint64_t) num,
 		s = num >> 122U;
 
-	return (v >> s) | (v << ((-s) & 63));
+	return (v >> s) | (v << ((~s + 1) & 63));
 }
 # endif
 

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ static inline uint64_t php_random_pcgoneseq128xslrr64_rotr64(php_random_uint128_`
`81`	`81`	`v = (num.hi ^ num.lo),`
`82`	`82`	`s = num.hi >> 58U;`
`83`	`83`
`84`		`- return (v >> s) \| (v << ((-s) & 63));`
	`84`	`+ return (v >> s) \| (v << ((~s + 1) & 63));`
`85`	`85`	`}`
`86`	`86`	`# else`
`87`	`87`	`typedef __uint128_t php_random_uint128_t;`
`@@ -121,7 +121,7 @@ static inline uint64_t php_random_pcgoneseq128xslrr64_rotr64(php_random_uint128_`
`121`	`121`	`v = ((uint64_t) (num >> 64U)) ^ (uint64_t) num,`
`122`	`122`	`s = num >> 122U;`
`123`	`123`
`124`		`- return (v >> s) \| (v << ((-s) & 63));`
	`124`	`+ return (v >> s) \| (v << ((~s + 1) & 63));`
`125`	`125`	`}`
`126`	`126`	`# endif`
`127`	`127`