fix these leaks.

Author: devnexen

ext/snmp/snmp.c

@@ -728,19 +728,22 @@ static bool php_snmp_parse_oid(
 						zval new;
 						ZVAL_COPY_VALUE(&new, tmp_type);
 						if (!try_convert_to_string(&new)) {
+							zend_string_release(tmp);
 							php_free_objid_query(objid_query, oid_ht, value_str, value_ht, st);
 							return false;
 						}
 						if (Z_STRLEN(new) != 1) {
 							zend_value_error("Type must be a single character");
+							zend_string_release(tmp);
 							php_free_objid_query(objid_query, oid_ht, value_str, value_ht, st);
 							return false;
 						}
 						pptr = Z_STRVAL(new);
 						objid_query->vars[objid_query->count].type = *pptr;
 						idx_type++;
 					} else {
-						php_error_docref(NULL, E_WARNING, "'%s': no type set", Z_STRVAL_P(tmp_oid));
+						php_error_docref(NULL, E_WARNING, "'%s': no type set", ZSTR_VAL(tmp));
+						zend_string_release(tmp);
 						php_free_objid_query(objid_query, oid_ht, value_str, value_ht, st);
 						return false;
 					}
@@ -775,7 +778,7 @@ static bool php_snmp_parse_oid(
 						objid_query->vars[objid_query->count].value = ZSTR_VAL(tmp);
 						idx_value++;
 					} else {
-						php_error_docref(NULL, E_WARNING, "'%s': no value set", Z_STRVAL_P(tmp_oid));
+						php_error_docref(NULL, E_WARNING, "'%s': no value set", ZSTR_VAL(tmp));
 						php_free_objid_query(objid_query, oid_ht, value_str, value_ht, st);
 						return false;
 					}

ext/snmp/tests/gh16959.phpt

@@ -25,6 +25,11 @@ try {
 
 try {
 	snmp2_set($hostname, $communityWrite, $bad_object_ids, array(new stdClass()), array(null));
+} catch (Throwable $e) {
+	echo $e->getMessage() . PHP_EOL;
+}
+try {
+	snmp2_set($hostname, $communityWrite, $bad_object_ids, array("toolongtype"), array(null));
 } catch (Throwable $e) {
 	echo $e->getMessage();
 }
@@ -55,3 +60,4 @@ array(4) {
 }
 Object of class stdClass could not be converted to string
 Object of class stdClass could not be converted to string
+Type must be a single character